Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with env vars and entrypoint #79

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Conversation

oskapt
Copy link
Contributor

@oskapt oskapt commented Feb 1, 2020

these are fixes for #78

i also single-quoted the echo line in make serve that uses backticks, because those sections were interpreted by the shell as actual docker commands and screwed up the output.

@mmou
Copy link
Contributor

mmou commented Feb 3, 2020

thank you @oskapt for the fixes in this PR, and the detailed issue writeup!

@mmou mmou merged commit 9d8ca06 into keybase:master Feb 3, 2020
@oskapt oskapt deleted the fix-docker branch February 10, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants