Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Commit

Permalink
Comment the relevant line where it seems things should fail
Browse files Browse the repository at this point in the history
I don't understand why what I've done works. This comment is meant to simply highlight the
line in the code that seems to be the cause of boot protocol failing without the earlier
changes I made (i.e. `boot_protocol_`).
  • Loading branch information
gedankenexperimenter committed May 21, 2022
1 parent 3606015 commit b8001cd
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/BootKeyboard/BootKeyboard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ bool BootKeyboard_::setup(USBSetup& setup) {
if (request == HID_GET_PROTOCOL) {
// TODO improve
#ifdef __AVR__
// This is where the `protocol` variable is used to set...something, but I don't
// know what. With the change that I've made to use `boot_protocol_` instead, this
// would always be set to `HID_REPORT_PROTOCOL`, even when sending boot protocol
// reports (successfully). It doesn't seem correct, but it works on macOS and Linux
// (or at least, my old Ubuntu machine).
UEDATX = protocol;
#endif
#ifdef ARDUINO_ARCH_SAM
Expand Down

0 comments on commit b8001cd

Please sign in to comment.