Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVELOPMENT tier workflow with KeymanHosts? #6

Open
darcywong00 opened this issue Nov 8, 2023 · 3 comments
Open

DEVELOPMENT tier workflow with KeymanHosts? #6

darcywong00 opened this issue Nov 8, 2023 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@darcywong00
Copy link
Contributor

Currently, the DEVELOPMENT tier in KeymanHosts changes nearly all Keyman site links to http://host.docker.internal:{port}.

} else if($this->tier == KeymanHosts::TIER_DEVELOPMENT) {
// Locally running sites via Docker need to access "host.docker.internal:[port]"
$this->s_keyman_com = "http://host.docker.internal:8054";
$this->api_keyman_com = "http://host.docker.internal:8058";
$this->help_keyman_com = "http://host.docker.internal:8055";
$this->downloads_keyman_com = "https://downloads.keyman.com"; // local dev domain is usually not available
$this->keyman_com = "http://host.docker.internal:8053";
$this->keymanweb_com = "http://host.docker.internal:8057";
$this->r_keymanweb_com = "https://r.keymanweb.com"; /// local dev domain is usually not available

Is there a workaround for when I'm only running one site locally on docker, and would rather the external Keyman sites use live links?

@darcywong00 darcywong00 added the question Further information is requested label Nov 8, 2023
@mcdurdin
Copy link
Member

mcdurdin commented Nov 8, 2023

This is tricky to solve. There are backend and frontend considerations. Perhaps links should automatically point to live sites by default, unless docker images are present. But that could mask API problems in your test environment, because it'd look like things are working correctly but it'd be because it'd be silently connecting to the frontend instead. (I've had this problem in the past.)

So ... not sure how best to address this.

@darcywong00
Copy link
Contributor Author

This can be deferred. I can just hand-edit KeymanHosts for now

@mcdurdin mcdurdin added this to the Future milestone Nov 13, 2023
@darcywong00
Copy link
Contributor Author

          I think LGTM. Can we rely on having website-local-proxy always running and use the same pattern for all the host.docker.internal references? That would avoid a lot of the confusion!

One challenge -- if we run the website-local-proxy on a port other than 80/443

Originally posted by @mcdurdin in #10 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants