Fixed LLVM_TARGETS_TO_BUILD in CMakeLists #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it seems that it is not possible to compile Keystone by picking individual architectures
For example, when using an external project, none of these work:
This PR fixes that by using space-separated targets in
LLVM_TARGETS_TO_BUILD
, and parsing with the CMake builtin commandseparate_arguments
, available since at least CMake 3.0 (I didn't check earlier versions)