Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upload progress in AdminUI for S3 uploads #816

Closed
morenoh149 opened this issue Dec 23, 2014 · 10 comments
Closed

Show upload progress in AdminUI for S3 uploads #816

morenoh149 opened this issue Dec 23, 2014 · 10 comments
Milestone

Comments

@morenoh149
Copy link
Contributor

After investigating the bug in keystonejs/keystone#532 is was determined that uploads were failing but the adminUI reported no errors. I suggest we do something more intelligent with the response object. Display a progress bar of the upload and display an error if the file wasn't stored to S3 properly. @JedWatson let me know if you think this is a good idea. See https://github.com/keystonejs/keystone/blob/master/lib/fieldTypes/s3file.js#L271 https://github.com/LearnBoost/knox#put If someone is interested in adding this functionality comment below. @weekwood @webteckie

@weekwood
Copy link
Contributor

@morenoh149 I'd like to handle it

@morenoh149
Copy link
Contributor Author

@weekwood any progress on this?

@weekwood
Copy link
Contributor

weekwood commented Jan 5, 2015

@morenoh149 I will send PR tom, which branch I should working on

@morenoh149
Copy link
Contributor Author

@weekwood if you don't have access to the keystone repo you can fork it and make the pull request from your own branch. See https://help.github.com/articles/using-pull-requests/

@weekwood
Copy link
Contributor

image
how can I update progress after I click save button, if I call

this.props.paths.progress

it is only works after refresh page.. any way to make it real time update from React? add a setInterval?

@morenoh149
Copy link
Contributor Author

Can you share what values you get if you add console.log('progress is', amountProgress); inside your uploader.on()

@weekwood
Copy link
Contributor

I got log like this.

progress is { percent: 0, written: 65536, total: 132178731 }

@morenoh149
Copy link
Contributor Author

interesting! Now the issue is getting the data from the server to the react view. Perhaps a socket.io instance? ping @BerkeleyTrue

@morenoh149
Copy link
Contributor Author

@weekwood two ways I can think of doing this.

pick one :)
update: actually don't we should make the adminUI an spa first keystonejs/keystone#903

@JedWatson JedWatson modified the milestones: Backlog, 0.3.x Jul 20, 2015
@mxstbr
Copy link
Collaborator

mxstbr commented Apr 29, 2016

We're closing all feature requests to keep the issue tracker unpolluted. I've moved this to ProductPains: https://productpains.com/post/keystonejs/show-upload-progress-in-adminui-for-uploads!

@mxstbr mxstbr closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants