-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show upload progress in AdminUI for S3 uploads #816
Comments
@morenoh149 I'd like to handle it |
@weekwood any progress on this? |
@morenoh149 I will send PR tom, which branch I should working on |
@weekwood if you don't have access to the keystone repo you can fork it and make the pull request from your own branch. See https://help.github.com/articles/using-pull-requests/ |
Can you share what values you get if you add |
I got log like this.
|
interesting! Now the issue is getting the data from the server to the react view. Perhaps a socket.io instance? ping @BerkeleyTrue |
@weekwood two ways I can think of doing this.
pick one :) |
We're closing all feature requests to keep the issue tracker unpolluted. I've moved this to ProductPains: https://productpains.com/post/keystonejs/show-upload-progress-in-adminui-for-uploads! |
After investigating the bug in keystonejs/keystone#532 is was determined that uploads were failing but the adminUI reported no errors. I suggest we do something more intelligent with the response object. Display a progress bar of the upload and display an error if the file wasn't stored to S3 properly. @JedWatson let me know if you think this is a good idea. See https://github.com/keystonejs/keystone/blob/master/lib/fieldTypes/s3file.js#L271 https://github.com/LearnBoost/knox#put If someone is interested in adding this functionality comment below. @weekwood @webteckie
The text was updated successfully, but these errors were encountered: