Copy updates #903

JedWatson · 2019-03-22T08:50:24Z

Some copy tweaks for readme and the website

jesstelford · 2019-03-22T08:52:19Z

README.md

-If you use the Knex adapter, KeystoneJS _will_ delete your database every time you restart your application.
+This project is currently very much in the `alpha` phase of development. There are known bugs, missing features, and limited documentation. APIs have not been finalised and may change with each release.
+
+To make this clear, we're currently publishing all packages to the `@keystone-alpha` scope on npm. As the project matures, we'll migrate over to our new `@keystone` scope and


oof, good catch! had the rest of that sentence written but not committed

jesstelford · 2019-03-22T08:53:48Z

README.md

+```bash
+brew install mongodb
+brew services start mongodb
+```


Could instead link to our docs for MongoDB: https://v5.keystonejs.com/quick-start/mongodb

jesstelford · 2019-03-22T08:58:43Z

README.md

+git clone https://github.com/keystonejs/keystone-5.git
+cd keystone-5
+bolt
+yarn start {project}


Suggested change

yarn start {project}

yarn build

yarn start {project}

Gotta run yarn build before yarn start

jesstelford · 2019-03-22T08:59:22Z

demo-projects/blog/README.md

+
+Although the "Password" auth strategy is enabled for the Admin UI on this project, we haven't implemented any restrictions on the GraphQL API yet. So unauthenticated users are able to create and destroy admin users (!)
+
+See the [Access Control](http://localhost:8000/guides/access-control) documentation for information on how to do this.


Suggested change

See the [Access Control](http://localhost:8000/guides/access-control) documentation for information on how to do this.

See the [Access Control](https://v5.keystonejs.com/guides/access-control) documentation for information on how to do this.

gautamsi · 2019-03-22T09:07:38Z

README.md

-
-<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
-<!-- prettier-ignore -->
-<table><tr><td align="center"><a href="http://www.thinkmill.com.au"><img src="https://avatars3.githubusercontent.com/u/872310?v=4" width="100px;" alt="Jed Watson"/><br /><sub><b>Jed Watson</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=JedWatson" title="Code">💻</a></td><td align="center"><a href="http://jes.st/about"><img src="https://avatars1.githubusercontent.com/u/612020?v=4" width="100px;" alt="Jess Telford"/><br /><sub><b>Jess Telford</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=jesstelford" title="Code">💻</a></td><td align="center"><a href="http://www.timl.id.au"><img src="https://avatars0.githubusercontent.com/u/616382?v=4" width="100px;" alt="Tim Leslie"/><br /><sub><b>Tim Leslie</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=timleslie" title="Code">💻</a></td><td align="center"><a href="https://hamil.town"><img src="https://avatars1.githubusercontent.com/u/11481355?v=4" width="100px;" alt="Mitchell Hamilton"/><br /><sub><b>Mitchell Hamilton</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=mitchellhamilton" title="Code">💻</a></td><td align="center"><a href="https://twitter.com/JossMackison"><img src="https://avatars3.githubusercontent.com/u/2730833?v=4" width="100px;" alt="Joss Mackison"/><br /><sub><b>Joss Mackison</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=jossmac" title="Code">💻</a></td><td align="center"><a href="http://nathansimpson.design"><img src="https://avatars2.githubusercontent.com/u/12689383?v=4" width="100px;" alt="Nathan Simpson"/><br /><sub><b>Nathan Simpson</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=nathansimpsondesign" title="Code">💻</a></td><td align="center"><a href="https://github.com/mikehazell"><img src="https://avatars0.githubusercontent.com/u/814227?v=4" width="100px;" alt="Mike"/><br /><sub><b>Mike</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=mikehazell" title="Code">💻</a></td></tr><tr><td align="center"><a href="https://github.com/molomby"><img src="https://avatars0.githubusercontent.com/u/2416367?v=4" width="100px;" alt="John Molomby"/><br /><sub><b>John Molomby</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=molomby" title="Code">💻</a></td><td align="center"><a href="https://dominik-wilkowski.com"><img src="https://avatars3.githubusercontent.com/u/1266923?v=4" width="100px;" alt="Dominik Wilkowski"/><br /><sub><b>Dominik Wilkowski</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=dominikwilkowski" title="Code">💻</a></td><td align="center"><a href="https://github.com/Noviny"><img src="https://avatars1.githubusercontent.com/u/15622106?v=4" width="100px;" alt="Ben Conolly"/><br /><sub><b>Ben Conolly</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=Noviny" title="Code">💻</a></td><td align="center"><a href="https://github.com/jaredcrowe"><img src="https://avatars1.githubusercontent.com/u/4995433?v=4" width="100px;" alt="Jared Crowe"/><br /><sub><b>Jared Crowe</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=jaredcrowe" title="Code">💻</a></td><td align="center"><a href="https://www.linkedin.com/in/gautamsi"><img src="https://avatars2.githubusercontent.com/u/5769869?v=4" width="100px;" alt="Gautam Singh"/><br /><sub><b>Gautam Singh</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=gautamsi" title="Code">💻</a></td><td align="center"><a href="https://github.com/lukebatchelor"><img src="https://avatars2.githubusercontent.com/u/18694878?v=4" width="100px;" alt="lukebatchelor"/><br /><sub><b>lukebatchelor</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=lukebatchelor" title="Code">💻</a></td><td align="center"><a href="http://www.ticidesign.com"><img src="https://avatars2.githubusercontent.com/u/289889?v=4" width="100px;" alt="Ticiana de Andrade"/><br /><sub><b>Ticiana de Andrade</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=ticidesign" title="Code">💻</a></td></tr><tr><td align="center"><a href="https://github.com/aghaabbasq"><img src="https://avatars2.githubusercontent.com/u/17919384?v=4" width="100px;" alt="aghaabbasq"/><br /><sub><b>aghaabbasq</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=aghaabbasq" title="Code">💻</a></td><td align="center"><a href="http://ajaymathur.github.io/"><img src="https://avatars1.githubusercontent.com/u/9667784?v=4" width="100px;" alt="Ajay Narain Mathur"/><br /><sub><b>Ajay Narain Mathur</b></sub></a><br /><a href="https://github.com/keystonejs/keystone-5/commits?author=ajaymathur" title="Code">💻</a></td></tr></table>


Will this make a comeback later?

Yep, just taking it out of the readme because the formatting is gross. We're planning to publish a page on the website for it so this is absolutely an interim step!

We're moving it to CONTRIBUTING.md 👍
https://github.com/keystonejs/keystone-5/pull/904

JedWatson added 3 commits March 22, 2019 19:42

Updating Readme

306c12e

Misc. website cleanup

645428a

Merge branch 'master' of https://github.com/keystonejs/keystone-5

2af19bf

JedWatson requested review from jesstelford and jossmac March 22, 2019 08:50

jesstelford suggested changes Mar 22, 2019

View reviewed changes

jesstelford reviewed Mar 22, 2019

View reviewed changes

Fix links and other suggestions

593e6b4

JedWatson requested a review from jesstelford March 22, 2019 09:01

gautamsi reviewed Mar 22, 2019

View reviewed changes

jesstelford approved these changes Mar 22, 2019

View reviewed changes

jesstelford merged commit 92b3952 into master Mar 22, 2019

jesstelford deleted the copy-updates branch March 22, 2019 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy updates #903

Copy updates #903

JedWatson commented Mar 22, 2019

jesstelford Mar 22, 2019

JedWatson Mar 22, 2019

jesstelford Mar 22, 2019

jesstelford Mar 22, 2019

jesstelford Mar 22, 2019

gautamsi Mar 22, 2019

JedWatson Mar 22, 2019

jesstelford Mar 22, 2019


		Although the "Password" auth strategy is enabled for the Admin UI on this project, we haven't implemented any restrictions on the GraphQL API yet. So unauthenticated users are able to create and destroy admin users (!)

		See the [Access Control](http://localhost:8000/guides/access-control) documentation for information on how to do this.

	See the [Access Control](http://localhost:8000/guides/access-control) documentation for information on how to do this.
	See the [Access Control](https://v5.keystonejs.com/guides/access-control) documentation for information on how to do this.

Copy updates #903

Copy updates #903

Conversation

JedWatson commented Mar 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment