Merge branch 'master' into checkbox-updates

.changeset/dirty-apricots-swim.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Updated system setup to only check for a valid `config.db.provider` once during `initConfig`.

.changeset/early-snakes-arrive.md

@@ -0,0 +1,6 @@
+---
+"@keystone-ui/notice": minor
+"@keystone-next/keystone": patch
+---
+
+Add Margin to error messages in the Admin UI Item Form

.changeset/forty-jobs-grow.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/cloudinary': major
+---
+
+Removed `isRequired` and `defaultValue` from the `cloudinaryImage` field. If you were using these options, the same behaviour can be re-created with the `validateInput` and `resolveInput` hooks respectively.

.changeset/gold-pillows-look.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+Removed the deprecated `config.db.adapter` option. Please use `config.db.provider` to indicate the database provider for your system.

.changeset/large-actors-worry.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Fixed Relationship field inline connect throwing 400 errors when selecting a value.

.changeset/nine-coins-yawn.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+Removed `context.schemaName` from the `context` object. This value was an internal API which is no longer required.

.changeset/popular-goats-juggle.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Fixed a bug in `context.db.lists` API when finding items that don't exist.

.changeset/real-jars-buy.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+Removed `isRequired` and `defaultValue` from the `image` and `file` fields. If you were using these options, the same behaviour can be re-created with the `validateInput` and `resolveInput` hooks respectively.

.changeset/rich-terms-love.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+Removed `defaultValue` and the undocumented `withMeta` option from the `relationship` field. To re-create `defaultValue`, you can use `resolveInput` though note that if you're using autoincrement ids, you need to return the id as number, not a string like you would provide to GraphQL, e.g. `{ connect: { id: 1 } }` rather than `{ connect: { id: "1" } }`. If you were using `withMeta: false`, please open an issue with your use case.

.changeset/short-jokes-hug.md

@@ -0,0 +1,6 @@
+---
+'@keystone-next/auth': major
+'@keystone-next/keystone': major
+---
+
+Renamed the `skipAccessControl` argument to `createContext` to `sudo` for consistency with `context.sudo()`.

.changeset/silver-boats-draw.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Removed unused `BaseKeystone` type.

.changeset/twelve-apples-happen.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Fixed lists with `graphql.omit: ['query']` causing issues in the Admin UI.

.changeset/twenty-buttons-teach.md

@@ -0,0 +1,6 @@
+---
+'@keystone-next/keystone': patch
+'@keystone-next/api-tests-legacy': patch
+---
+
+Improved error message for bad relationship filter inputs.

.changeset/violet-lions-attend.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+The item view page will only fetch the item once to determine the field modes rather than once per field.

.changeset/wise-garlics-swim.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': major
+---
+
+The Admin UI will skip fetching fields that have a statically set `itemView.fieldMode: 'hidden'` on the item view. The `id` argument to the `KeystoneAdminUIFieldMeta.itemView` GraphQL field can now be omitted which will make `KeystoneAdminUIFieldMetaItemView.fieldMode` return null when there isn't a static field mode. The `itemView` also no longer uses a sudo context when fetching the item in the `KeystoneAdminUIFieldMetaItemView.fieldMode`. Previously, if someone had access to the Admin UI(`ui.isAccessAllowed`) and a field had a `itemView.fieldMode` function that used the `item` argument, someone could bypass access control to determine whether or not an item with a given id exists.

design-system/packages/notice/src/Notice.tsx

@@ -2,7 +2,7 @@
 /** @jsx jsx */
 
 import { ReactNode, useMemo } from 'react';
-import { jsx, makeId, useId, Stack } from '@keystone-ui/core';
+import { jsx, makeId, useId, Stack, MarginProps, Box } from '@keystone-ui/core';
 import { AlertOctagonIcon } from '@keystone-ui/icons/icons/AlertOctagonIcon';
 import { AlertCircleIcon } from '@keystone-ui/icons/icons/AlertCircleIcon';
 import { AlertTriangleIcon } from '@keystone-ui/icons/icons/AlertTriangleIcon';
@@ -36,7 +36,7 @@ type NoticeProps = {
   tone?: ToneKey;
   title?: string;
   className?: string;
-} /* TODO: & MarginProps */;
+} & MarginProps;
 
 export const Notice = ({
   actions,
@@ -60,7 +60,7 @@ export const Notice = ({
 
   return (
     <ButtonProvider {...buttonContext}>
-      <div
+      <Box
         css={{
           display: 'flex',
           flex: 1,
@@ -97,7 +97,7 @@ export const Notice = ({
             </Stack>
           )}
         </div>
-      </div>
+      </Box>
     </ButtonProvider>
   );
 };

design-system/website/pages/components/popover.tsx

@@ -1,8 +1,8 @@
 /** @jsxRuntime classic */
 /** @jsx jsx */
 
-import { jsx, Box } from '@keystone-ui/core';
 import { Button } from '@keystone-ui/button';
+import { Box, jsx } from '@keystone-ui/core';
 import { Popover } from '@keystone-ui/popover';
 import { Page } from '../../components/Page';
 
@@ -20,7 +20,7 @@ export default function PopoverPage() {
         styles for height and width.
       </p>
       <Popover triggerRenderer={({ triggerProps }) => <Button {...triggerProps}>Click me</Button>}>
-        <Box width={180} height={80} padding="medium">
+        <Box tabIndex={0} width={180} height={80} padding="medium">
           I'm in a popover!
         </Box>
       </Popover>

docs/pages/docs/apis/context.mdx

@@ -57,7 +57,6 @@ context = {
   // Internal state
   totalResults,
   maxTotalResults,
-  schemaName,
 
   // Deprecated
   gqlNames,
@@ -155,8 +154,6 @@ These properties are used internally by Keystone and generally do not need to be
 
 `maxTotalResults`: The maximum number of results which can be returned before a query limit error is triggered. See [`config.graphql.queryLimits`](./apis/config#graphql).
 
-`schemaName`: The internal name used by Keystone to refer to the GraphQL schema.
-
 ### Deprecated
 
 The following properties are deprecated and should not be used.

docs/pages/docs/apis/fields.mdx

@@ -632,10 +632,6 @@ A `file` field represents a file of any type.
 
 See [`config.files`](./config#files) for details on how to configure your Keystone system with support for the `file` field type.
 
-Options:
-
-- `isRequired` (default: `false`): If `true` then this field can never be set to `null`.
-
 ```typescript
 import { config, createSchema, list } from '@keystone-next/keystone';
 import { file } from '@keystone-next/keystone/fields';
@@ -644,9 +640,7 @@ export default config({
   lists: createSchema({
     ListName: list({
       fields: {
-        repo: file({
-          isRequired: true,
-        }),
+        repo: file(),
         /* ... */
       },
     }),
@@ -662,10 +656,6 @@ An `image` field represents an image file, i.e. `.jpg`, `.png`, `.webp`, or `.gi
 
 See [`config.images`](./config#images) for details on how to configure your Keystone system with support for the `image` field type.
 
-Options:
-
-- `isRequired` (default: `false`): If `true` then this field can never be set to `null`.
-
 ```typescript
 import { config, createSchema, list } from '@keystone-next/keystone';
 import { image } from '@keystone-next/keystone/fields';
@@ -674,9 +664,7 @@ export default config({
   lists: createSchema({
     ListName: list({
       fields: {
-        avatar: image({
-          isRequired: true,
-        }),
+        avatar: image(),
         /* ... */
       },
     }),
@@ -733,7 +721,6 @@ export default config({
 
 (coming soon)
 
-- `isRequired` (default: `false`): If `true` then this field can never be set to `null`.
 - `cloudinary`: Configuration for the connected Cloudinary account.
   - `cloudName`
   - `apiKey`
@@ -749,7 +736,6 @@ export default config({
     ListName: list({
       fields: {
         fieldName: cloudinaryImage({
-          isRequired: true,
           cloudinary: {
             cloudName: process.env.CLOUDINARY_CLOUD_NAME,
             apiKey: process.env.CLOUDINARY_API_KEY,

examples-staging/assets-cloud/schema.graphql

@@ -280,7 +280,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -303,7 +303,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/assets-local/schema.graphql

@@ -258,7 +258,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -281,7 +281,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/auth/schema.graphql

@@ -201,7 +201,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -224,7 +224,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/basic/schema.graphql

@@ -447,7 +447,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -470,7 +470,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/ecommerce/schema.graphql

@@ -830,7 +830,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -853,7 +853,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/ecommerce/schemas/Product.ts

@@ -44,8 +44,15 @@ export const Product = list({
     price: integer(),
     user: relationship({
       ref: 'User.products',
-      defaultValue: ({ context }) =>
-        context.session?.itemId ? { connect: { id: context.session?.itemId } } : null,
+      hooks: {
+        resolveInput({ operation, resolvedData, context }) {
+          // Default to the currently logged in user on create.
+          if (operation === 'create' && !resolvedData.user && context.session?.itemId) {
+            return { connect: { id: context.session?.itemId } };
+          }
+          return resolvedData.user;
+        },
+      },
     }),
   },
 });

examples-staging/embedded-nextjs/schema.graphql

@@ -125,7 +125,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -148,7 +148,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/graphql-api-endpoint/schema.graphql

@@ -376,7 +376,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -399,7 +399,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {

examples-staging/roles/schema.graphql

@@ -386,7 +386,7 @@ type KeystoneAdminUIFieldMeta {
   customViewsIndex: Int
   createView: KeystoneAdminUIFieldMetaCreateView!
   listView: KeystoneAdminUIFieldMetaListView!
-  itemView(id: ID!): KeystoneAdminUIFieldMetaItemView
+  itemView(id: ID): KeystoneAdminUIFieldMetaItemView
   search: QueryMode
 }
 
@@ -409,7 +409,7 @@ enum KeystoneAdminUIFieldMetaListViewFieldMode {
 }
 
 type KeystoneAdminUIFieldMetaItemView {
-  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode!
+  fieldMode: KeystoneAdminUIFieldMetaItemViewFieldMode
 }
 
 enum KeystoneAdminUIFieldMetaItemViewFieldMode {