Session manager updates #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timleslie
force-pushed
the
session-manager
branch
3 times, most recently
from
a979fcc
to
0366566
Compare
jesstelford
approved these changes
Dec 7, 2018
timleslie
force-pushed
the
session-manager
branch
from
0366566
to
d22820b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
keystone.sessiontokeystone.sessionManager. Within this class, the methods are renamed:validate->populateAuthedItemMiddlewarecreate->startAuthedSessiondestroy->endAuthedSessionThis hopefully makes it more clear what is going on within this subsystem of keystone. These changes are motivated by a desire to investigate #303. The existing names of
session,create, andvalidateare all used in other parts of the system to mean different things. Renaming them makes them easier to uniquely search for which in turn makes it easier to investigate where and how they are used.