Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor addition to Stack #5858

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Minor addition to Stack #5858

merged 3 commits into from
Jun 4, 2021

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented Jun 4, 2021

If the Stack element is changed to an ol or ul via the as prop, the component now automatically wraps children in li as opposed to a div.

All other tags fallback to the div behaviour.

QOL fix to reduce div soup in situations where we want to use the Stack component for lists.

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2021

🦋 Changeset detected

Latest commit: e996578

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-ui/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8YQSfExeFeNGxS3TCNkQvZVWcyTR
✅ Preview: https://keystone-next-docs-git-design-system-add-to-stack-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 4, 2021 05:33 Inactive
@gwyneplaine gwyneplaine requested a review from a team June 4, 2021 05:34
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview June 4, 2021 05:36 Inactive
@gwyneplaine gwyneplaine enabled auto-merge (squash) June 4, 2021 05:36
@gwyneplaine gwyneplaine merged commit 8958704 into master Jun 4, 2021
@gwyneplaine gwyneplaine deleted the design-system/add-to-stack branch June 4, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants