Website plumbing updates #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timleslie
force-pushed
the
website-updates
branch
4 times, most recently
from
df5e251
to
c2b09a3
Compare
jesstelford
reviewed
Mar 13, 2019
website/src/components/Sidebar.js
Outdated
| .filter(({ path }) => `/${navGroup}/` !== path) | ||
| .map(node => { | ||
| return ( | ||
| <li key={node.path} css={{}}> |
There was a problem hiding this comment.
Can remove the empty css={{}} prop here.
There was a problem hiding this comment.
Joss is doing a big cleanup of this kind of thing in #823, so I'll leave this in for now so as not to add confusion to the upcoming merges.
jesstelford
approved these changes
Mar 13, 2019
timleslie
force-pushed
the
website-updates
branch
from
c2b09a3
to
8ef316c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logic around which files we render to the website and how they're arranged in the nav bar.