Chore/FAVE-37047 Switch to New Domain Names Due to The Alipay+ Network Upgrade #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI Documentation
…original-repo Add Integration for Create QR Code, Update QR Code, Overseas Query, Spot Refund
fix failed timezone test
zhenghui97
force-pushed
the
chore/FAVE-37047-reset-to-upstream
branch
from
f7f8ee1
to
06b75b0
Compare
…reset-to-upstream
zhenghui97
force-pushed
the
chore/FAVE-37047-reset-to-upstream
branch
2 times, most recently
from
2fc81a1
to
81d30b1
Compare
zhenghui97
force-pushed
the
chore/FAVE-37047-reset-to-upstream
branch
from
81d30b1
to
b811232
Compare
kahshing96
reviewed
May 20, 2024
lib/alipay/service.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| module Alipay | |||
| module Service | |||
| GATEWAY_URL = 'https://mapi.alipay.com/gateway.do' | |||
| GATEWAY_URL = 'https://api-sea-global.alipayplus.com/gateway.do' | |||
There was a problem hiding this comment.
perhaps we can try to declare an attr_accessor in the alipay.rb instead of hardcoding the URL, so we can accessed globally with something like this Alipay.legacy_gateway_url, it's easier to configure later with different value without the need to change in the gem code (eg: configure in rails initializer)
Line 25 in 63959f8
zhenghui97
force-pushed
the
chore/FAVE-37047-reset-to-upstream
branch
from
679b76a
to
d15850e
Compare
kahshing96
approved these changes
May 21, 2024
zhenghui97
force-pushed
the
chore/FAVE-37047-reset-to-upstream
branch
from
e2fae72
to
d15850e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*Refer to chloerei/alipay@master...kfit-dev:alipay:chore/FAVE-37047-reset-to-upstream to see the actual differences compared to the upstream.
Context or Ticket
https://kfit-asia.atlassian.net/browse/FAVE-37047