Skip to content

Commit

Permalink
Remove unused code, fix apache#3070 (apache#3073)
Browse files Browse the repository at this point in the history
  • Loading branch information
CrazyHZM authored and khanimteyaz committed Jan 18, 2019
1 parent 01dbc20 commit e0f960a
Showing 1 changed file with 1 addition and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -291,20 +291,6 @@ private static Method getMethodByName(Class<?> clazz, String methodName) {
}
}

/**
* We only check boolean value at this moment.
*
* @param type
* @param value
* @return
*/
private static boolean isTypeMatch(Class<?> type, String value) {
if ((type == boolean.class || type == Boolean.class)
&& !("true".equals(value) || "false".equals(value))) {
return false;
}
return true;
}

protected static void checkExtension(Class<?> type, String property, String value) {
checkName(property, value);
Expand Down Expand Up @@ -565,7 +551,7 @@ public void refresh() {
config.addProperties(getMetaData());
if (Environment.getInstance().isConfigCenterFirst()) {
// The sequence would be: SystemConfiguration -> ExternalConfiguration -> AppExternalConfiguration -> AbstractConfig -> PropertiesConfiguration
compositeConfiguration.addConfiguration(3,config);
compositeConfiguration.addConfiguration(3, config);
} else {
// The sequence would be: SystemConfiguration -> AbstractConfig -> ExternalConfiguration -> AppExternalConfiguration -> PropertiesConfiguration
compositeConfiguration.addConfiguration(1, config);
Expand Down

0 comments on commit e0f960a

Please sign in to comment.