[1.20] Camera look straight up down FINISH #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready for replacing dynamic camera rotating logic. Simplify dynamic camera rotating logic. Replace small camera rotating methods. Add simpler logic for replacing small methods.
Add real isKeyPressed method. Rename isKeyPressed method to isKeyPressing. Make all KeystrokeChecker test cases use one data supplier. Add isKeyReleased method for KeystrokeChecker. Rename MockKeyStroke. Fix MockKeyStroke bug. Add hasKeyPressedPreviousTick for KeystrokeChecker. Import unit test dependencies into common package.
Replace more if condition with KeystrokeChecker. Add isNotPressing method to KeystrokeChecker. Simplify KeystrokeChecker methods name. Replace logic with KeystrokeChecker in NarratorMenu. Simplify KeystrokeChecker methods name.
New KeystrokeTiming class for reusing. Rename KeystrokeChecker to Keystroke. Move Interval and KeystrokeChecker to new subpackage. Move Interval to independent file. Move KeystrokeChecker to independent file.
Add hasBeenTriggered method. Add pressed trigger count test. Add released trigger count test. Add not pressing trigger count test. Add pressing trigger count test. Change unit test structure for further cases. Add tests for Keystroke.TriggeredAt enums. Arrange logic order in KeystrokeTest.
Make hasPressedPreviousTick private. Rename method. Make isTriggered a pure-function. Simplify keys name in NarratorMenu.
Enhance a test case for DoubleClick. Make default interval in KeystrokeTiming not a singleton. Fill document. Rename MockKeystroke to MockKeystrokeAction for not confuse with the Keystroke class. Add one more test case for DoubleClick. Add /common/logs/ to gitignore. Test DoubleClick can clean stale count. Add MockInterval for simulating time passing. test DoubleClick can count trigger. Remove unnecessary imports. Add timing init arg to KeystrokeTiming. Move MockKeystroke to independent class. Move KeystrokeTest under subpackage. Add default multiple click speed config as 750ms. Prepare for implementing DoubleClick.
khanshoaib3
approved these changes
Aug 20, 2023
|
Close #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge #132 first for less review burden.
DoubleClickkeystroke checker util for this feature's requirement.Look Straight UpandLook Straight Downkeys toCamera Controls#123