Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N SlotsGroup #30

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

boholder
Copy link
Collaborator

@boholder boholder commented May 18, 2023

Finish TODO about I18N SlotsGroup, following with khanshoaib3/minecraft-access-i18n#2

@khanshoaib3 khanshoaib3 merged commit ca33e74 into khanshoaib3:default May 19, 2023
@boholder boholder deleted the i18n-slots-group branch May 24, 2023 12:29
@boholder
Copy link
Collaborator Author

boholder commented May 24, 2023

Wait wait wait, some slot groups (like amour group, it's groupName is Armor, not armor) doesn't work! I'll fix it ASAP

Sometime it works, sometime it doesn't work. I don't know why, this method

private static @NotNull List<SlotsGroup> commonGroups(@NotNull HandledScreenAccessor screen) {

should be called in every tick and so it does.

if (inventoryControls != null && config.getConfigMap().getInventoryControlsConfigMap().isEnabled())
inventoryControls.update();

@boholder
Copy link
Collaborator Author

Found the reason: there are some SlotsGroup instances are initialized with non-config-key groupName

@boholder boholder added the 1.19 Minecraft 1.19.* version (1.19.3 in fact) label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 Minecraft 1.19.* version (1.19.3 in fact)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants