add drop arg to indexing; resolve #14

khusmann · Oct 12, 2024 · 0038cf2 · 0038cf2
1 parent 2ab68b9
commit 0038cf2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/R/interlaced.R b/R/interlaced.R
@@ -465,7 +465,7 @@ vec_proxy_order.interlacer_interlaced <- function(x, ...) {
 # Subsetting --------------------------------------------------------------
 
 #' @export
-`[.interlacer_interlaced` <-  function(x, i, ...) {
+`[.interlacer_interlaced` <-  function(x, i, ..., drop) {
   if (!missing(...)) {
     cli_abort("Can't index interlaced vectors on dimensions greater than 1.")
   }

diff --git a/tests/testthat/test-interlaced.R b/tests/testthat/test-interlaced.R
@@ -125,6 +125,10 @@ test_that("indexing operates on underlying channels", {
   # multidimensional indexing errors
   expect_error(foo[1, 2])
   expect_error(foo[[1, 2]])
+
+  # indexing with drop works
+  expect_equal(foo[, drop = TRUE], foo)
+  expect_equal(foo[, drop = FALSE], foo)
 })
 
 test_that("indexing assignment casts & operates on underlying channels", {