client: Update kubevirt.io/client-go to v1.0.0 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
reviewed
Sep 27, 2023
There was already a pin to an older version. |
It is. I'm just saying that it's worth mentioning. won't insist on it though. |
orelmisan
force-pushed
the
kubevirt-client-go
branch
from
6244987
to
2d9687b
Compare
Currently, we are using kubevirt.io/[email protected]. Update to v1.0.0 in order to: 1. Take advantage of context.Context parameter that was added to VMI methods. 2. Eliminate the following warning from the checkup's logs: ``` W0702 08:56:11.138067 1 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release. ``` Pin K8s deps to v0.26.3 to match definitions set in kubevirt.io/client-go. Signed-off-by: Orel Misan <[email protected]>
orelmisan
force-pushed
the
kubevirt-client-go
branch
from
2d9687b
to
95b333d
Compare
|
Updated commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using kubevirt.io/[email protected].
Update to v1.0.0 in order to:
Pin K8s deps to v0.26.3 to match definitions set in kubevirt.io/client-go.