Log in as root #58
Merged
Log in as root #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when logging in as root - the login operation fails because of a mistake in the directory name expected by `loggedInPromptRegex`. Signed-off-by: Orel Misan <[email protected]>
Currently, the checkup creates a `cloud-user` user using cloud-init, and logs in to the VMs using its credentials. Immediately after logging in, the checkup issues the `sudo su` command, thus effectively running as the root user. Logging in as root simplifies the login operation, and remove problems that can occur when certain assumptions are made when performing the `sudo su` step - for example: 1. Not expecting the sudo warning message 2. Not expecting to enter the user's password again. Also remove the creation cloud-init volume, since it is no longer needed. Signed-off-by: Orel Misan <[email protected]>
`configureConsole` is only used in login.go. Signed-off-by: Orel Misan <[email protected]>
Since we log in as root, there is no need to have support for sudo. Signed-off-by: Orel Misan <[email protected]>
Since we only log in as `root` - simply `LoginToCentOS` and rename it to match its abilities. Signed-off-by: Orel Misan <[email protected]>
|
Tested against an OpenShift Virtualization 4.15 cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the checkup creates a
cloud-useruser using cloud-init, and logs in to the VM using its credentials.Immediately after logging in, the checkup issues the
sudo sucommand, thus effectively running as the root user.Logging in as root simplifies the login operation, and remove problems that can occur when certain assumptions are made when performing the
sudo sustep - for example:Also remove the creation of
cloud-uservolume, since it is no longer needed.Based on work done in kiagnose/kubevirt-dpdk-checkup#225.