Fix some code and add UTs #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shelly Kagan <[email protected]>
Signed-off-by: Shelly Kagan <[email protected]>
Signed-off-by: Shelly Kagan <[email protected]>
In case there are no valid golden images also in the case where the golden image doesnt have data source we dont want to exit the checkup we can continue to the next check which is check existing VMIs and then on the checks that are dependent on the golden images we should show the same message and skip. Signed-off-by: Shelly Kagan <[email protected]>
adjust reporter UT adjusr checkup UT add negative UT for checkup Signed-off-by: Shelly Kagan <[email protected]>
Signed-off-by: Shelly Kagan <[email protected]>
arnongilboa
reviewed
Dec 5, 2023
Comment on lines
46
to
59
| tests := map[string]struct { | ||
| checkup checkupStub | ||
| reporter reporterStub | ||
| errors []string | ||
| }{ | ||
| "report fails": {checkup: checkupStub{}, reporter: reporterStub{failReport: errReport}, errors: []string{errReport.Error()}}, | ||
| "setup fails": {checkup: checkupStub{failSetup: errSetup}, reporter: reporterStub{}, errors: []string{errSetup.Error()}}, | ||
| "run fails": {checkup: checkupStub{failRun: errRun}, reporter: reporterStub{}, errors: []string{errRun.Error()}}, | ||
| "teardown fails": {checkup: checkupStub{failTeardown: errTeardown}, reporter: reporterStub{}, errors: []string{errTeardown.Error()}}, | ||
| "setup and 2nd report fail": {checkup: checkupStub{failSetup: errSetup}, reporter: reporterStub{failReport: errReport, failOnSecondReport: true}, errors: []string{errSetup.Error(), errReport.Error()}}, | ||
| "run and report fail": {checkup: checkupStub{failRun: errRun}, reporter: reporterStub{failReport: errReport, failOnSecondReport: true}, errors: []string{errRun.Error(), errReport.Error()}}, | ||
| "teardown and report fail": {checkup: checkupStub{failTeardown: errTeardown}, reporter: reporterStub{failReport: errReport, failOnSecondReport: true}, errors: []string{errTeardown.Error(), errReport.Error()}}, | ||
| "run, teardown and report fail": {checkup: checkupStub{failRun: errRun, failTeardown: errTeardown}, reporter: reporterStub{failReport: errReport, failOnSecondReport: true}, errors: []string{errRun.Error(), errTeardown.Error(), errReport.Error()}}, | ||
| } |
arnongilboa
reviewed
Dec 5, 2023
pkg/internal/checkup/checkup.go
Outdated
Comment on lines
81
to
83
| // FIXME: need to decide of we want to return errors in this cases | ||
| // errMissingVolumeSnapshotClass = "There are StorageProfiles missing VolumeSnapshotClass." | ||
| // errVMsWithNonVirtRbdStorageClass = "There are VMs using the plain RBD storageclass when the virtualization storageclass exists." |
There was a problem hiding this comment.
Afaiu, we shoud report these cases in the status but not fail the checkup
arnongilboa
reviewed
Dec 5, 2023
pkg/internal/checkup/checkup_test.go
Outdated
| }, | ||
| "storageProfileIncomplete": { | ||
| clientConfig: clientConfig{spIncomplete: true}, | ||
| expectedResults: map[string]string{reporter.StorageProfilesWithEmptyClaimPropertySetsKey: testScName, reporter.StorageProfilesWithSpecClaimPropertySetsKey: testScName, reporter.StorageWithRWXKey: ""}, |
There was a problem hiding this comment.
Not sure how can a SC be on both EmptyClaimPropertySets and SpecClaimPropertySets? I guess only in UT it's possible :)
arnongilboa
approved these changes
Dec 6, 2023
|
@ShellyKa13 please sign the commits |
They are signed it seems signed commits by github is not the DCO check we do in other repos. I changed the settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code fixes:
Adjust UT accordingly adjust and add negative UTs