Log OCP and CNV versions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnon Gilboa <[email protected]>
Signed-off-by: Arnon Gilboa <[email protected]>
arnongilboa
force-pushed
the
log_versions
branch
from
673155c
to
e7164d6
Compare
ShellyKa13
reviewed
Jan 4, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| if len(cdis.Items) != 1 { |
There was a problem hiding this comment.
maybe check if ==0 then have an error that it doesnt exist and if bigger then one then this current msg?
| } | ||
| ocpVersion := "" | ||
| for _, update := range ver.Status.History { | ||
| if update.State == configv1.CompletedUpdate { |
There was a problem hiding this comment.
and there is always only on update that has that state? or if not are they sorted by old->new? cause if not you will not get the last version necessarily. Just making sure :)
There was a problem hiding this comment.
See doc: The newest update is first in the list and it is ordered by recency.
| @@ -621,6 +623,37 @@ func (cs *clientStub) GetDataSource(ctx context.Context, namespace, name string) | |||
| return das, nil | |||
| } | |||
|
|
|||
| func (cs *clientStub) GetClusterVersion(ctx context.Context, name string) (*configv1.ClusterVersion, error) { | |||
There was a problem hiding this comment.
what about a UT to make sure you get the last updated version? and maybe also negative testing.. although it is pretty straight foreword function..
There was a problem hiding this comment.
Will add the positive one :)
Signed-off-by: Arnon Gilboa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also go mod tidy && go mod vendor (required for the OpenShift APIs)