KIALI-2129 UXD: Move the grafana link to the topbar #876
Conversation
| @@ -4,7 +4,8 @@ import { RouteComponentProps, withRouter } from 'react-router'; | |||
| import Metrics, { MetricsProps } from '../components/Metrics/Metrics'; | |||
|
|
|||
| const mapStateToProps = (state: KialiAppState) => ({ | |||
| isPageVisible: state.globalState.isPageVisible | |||
| isPageVisible: state.globalState.isPageVisible, | |||
| grafanaInfo: state.grafanaInfo | |||
| }); | |||
There was a problem hiding this comment.
Added here the link for workloads @jotak
|
from UX perspective looking per the design. cc @cshinn |
|
@aljesusg I'm not sure if it's related to your PR, but when I'm entering in metrics page I can see that the grafana info is being fetched twice. Hence if I'm having incorrect settings for Grafana I see the error twice. |
|
ok @jotak I was not sure about add the every label, about the fetch of the grafana info I think that we can change this since we have this information when the user login kiali, we don't need fetch again. |
| 30000: '30 sec', | ||
| 60000: '1 min', | ||
| 300000: '5 min' | ||
| 5000: 'Every 5 sec', |
There was a problem hiding this comment.
This makes the graph refresh duplicate "Every": it's now showing like "Every Every 15 sec" :)
There was a problem hiding this comment.
Hahhaa I'll cahnge it ^^
|
@aljesusg do the testing for this again with the proper (built) Kiali UI, this might be affected by facebook/react#12856. |
|
Oh, my bad, sorry about that. |
** Describe the change **
** Issue reference **
JIRA: KIALI-2129
** Screenshot **
Services inbound metrics
Workload outbound metrics
Workload inbound metrics