🐛 Remove Auth headers from request if auth is not needed #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kf-ui-fhir-cohort-builder ready! Built with commit 779a0bb https://deploy-preview-108--kf-ui-fhir-cohort-builder.netlify.app |
znatty22
requested changes
Aug 7, 2020
There was a problem hiding this comment.
I think something is still not quite right. Here's what I'm doing:
- Launch dashboard with localhost (npm start and make sure to have localhost in my .env)
- Click Servers
- Change Localhost auth type from BASIC_AUTH to NO_AUTH
- Launch
- I'm seeing a
Basic undefinedin the Authorization request header
also doesnt send auth header if a url uses a proxy url
abgeorge7
force-pushed
the
fix/auth-header
branch
from
c74db52
to
779a0bb
Compare
|
I cant reproduce :( whats your .env file? |
znatty22
approved these changes
Aug 13, 2020
znatty22
added a commit
that referenced
this pull request
Aug 14, 2020
## Release 0.3.0 ### Summary - Emojis: ♻️ x1, 🐛 x2 - Categories: Other Changes x1, Fixes x2 ### New features and changes - [#109](#109) - ♻️ Updating old default urls to be the KF dev and QA urls - [2c31931](2c31931) by [abgeorge7](https://github.com/abgeorge7) - [#108](#108) - 🐛 Remove Auth headers from request if auth is not needed - [02665f1](02665f1) by [abgeorge7](https://github.com/abgeorge7) - [#107](#107) - 🐛 Add missing env vars to Docker Compose - [4c66efd](4c66efd) by [znatty22](https://github.com/znatty22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NIH-NCPI#8
Also doesn't send auth header if a url uses a proxy url