-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Table to show resources that reference a given ID #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm so what is the behavior if there is more than one (for example) Biosample referencing a Patient? |
In your example, you had 1 Biosample referencing your Patient instance. I just meant that instead of showing all possible Biospecimens (2229), you should show the ones (however many there are) that reference that Patient instance. |
I'm wondering if it makes more sense to show the payloads of the reference resources? I guess my question is, is it a use case that a user would want to see just a snapshot of the resource references? or do they just want to know the IDs? this kind of gets into filtering resources/cohorts building/etc and I just want to make sure that it fits in with our goal for this dashboard, if that makes sense. Could also show the IDs and then clicking on an ID shows the payload? |
👍 People are definitely interested in seeing more than just the ID. I would say this is one of our most common use cases with the KF data service. With data service you do this:
|
de6eda5
to
4e28281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think you just need to rebase on master and then its ✅. GH will force me to re-approve after you rebase so might as well wait until thats done
785d1eb
to
9c4cf3f
Compare
Reference resources now show how many of that resource type are a reference
Fixed css bug where table overflows modal. Also fixed bug that caused an error if a resource didn't have a name or profile attached to it.
On clicking a row in the reference table, a list of IDs that reference the given ID are show.
Click on a child row with a reference ID shows the payload for that ID
Variable import went missing in rebase
9c4cf3f
to
96d52f4
Compare
Deploy preview for kf-ui-fhir-cohort-builder ready! Built with commit c4c12f7 https://deploy-preview-27--kf-ui-fhir-cohort-builder.netlify.com |
Counting for base resources is by looking at all the resources with profiles and subtracting them from the total.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, it looks really good! Can you add a blurb on using the react app env vars to the README?
Added info about the environment variables for auth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖 💯
## Release 0.1.0 ### Summary - Emojis: 👷 x3, ✅ x5, ♻️ x5, 🐛 x5, 🐳 x1, ✨ x10, 🥅 x1, 💄 x4, ⚡️ x1, 📝 x2, ? x1 - Categories: Ops x4, Other Changes x16, Fixes x6, Additions x10, Documentation x2 ### New features and changes - [#88](#88) - 👷 Add GH release workflow - [698ec2c](698ec2c) by [znatty22](https://github.com/znatty22) - [#83](#83) - 👷 Deploy dashboard to production - [e49ddde](e49ddde) by [znatty22](https://github.com/znatty22) - [#78](#78) - ✅ Add server tests - [1e7296a](1e7296a) by [abgeorge7](https://github.com/abgeorge7) - [#77](#77) - ✅ Add attribute details page tests - [f3158f8](f3158f8) by [abgeorge7](https://github.com/abgeorge7) - [#76](#76) - ✅ Add resource details/chart page tests - [2f0041e](2f0041e) by [abgeorge7](https://github.com/abgeorge7) - [#75](#75) - ✅ Add resource ID details tests - [ddb4d62](ddb4d62) by [abgeorge7](https://github.com/abgeorge7) - [#73](#73) - ✅ Add Homepage tests - [b100edb](b100edb) by [abgeorge7](https://github.com/abgeorge7) - [#72](#72) - ♻️ Dashboard redesign - [9189ead](9189ead) by [abgeorge7](https://github.com/abgeorge7) - [#71](#71) - 🐛 Adding statement to update table when props change - [9488860](9488860) by [abgeorge7](https://github.com/abgeorge7) - [#69](#69) - 🐛 Use id instead of resource name for $snapshot - [c014781](c014781) by [abgeorge7](https://github.com/abgeorge7) - [#66](#66) - 👷 Tag docker img with git commit hash - [a648b0d](a648b0d) by [znatty22](https://github.com/znatty22) - [#65](#65) - 🐳 Dockerize the app - [dade57e](dade57e) by [znatty22](https://github.com/znatty22) - [#63](#63) - ♻️ Use $snapshot endpoint - [87dc929](87dc929) by [abgeorge7](https://github.com/abgeorge7) - [#59](#59) - ♻️ Refactoring reducers and server configuration - [4de0597](4de0597) by [abgeorge7](https://github.com/abgeorge7) - [#58](#58) - ✨ Configuration UI for adding/updating a server - [3379974](3379974) by [abgeorge7](https://github.com/abgeorge7) - [#50](#50) - 🥅 Error handling - [90fa22f](90fa22f) by [abgeorge7](https://github.com/abgeorge7) - [#49](#49) - 💄 JSON payloads are formatted on details view - [2534382](2534382) by [abgeorge7](https://github.com/abgeorge7) - [#47](#47) - ♻️ Updating app name in package.json - [8d00515](8d00515) by [abgeorge7](https://github.com/abgeorge7) - [#46](#46) - ✨ All tables are searchable - [d58f683](d58f683) by [abgeorge7](https://github.com/abgeorge7) - [#44](#44) - 🐛 Removed values with no data from bar charts - [52dbd76](52dbd76) by [abgeorge7](https://github.com/abgeorge7) - [#41](#41) - ✨ Clicking on a chart sector shows table of resources where attribute = selected value - [834a5bc](834a5bc) by [abgeorge7](https://github.com/abgeorge7) - [#40](#40) - 🐛 Adding spinner to Ontology page - [a7793d6](a7793d6) by [abgeorge7](https://github.com/abgeorge7) - [#37](#37) - ✨ References include resources referenced by the given ID - [8a364e7](8a364e7) by [abgeorge7](https://github.com/abgeorge7) - [#35](#35) - ✨ Charts show extensions - [0a1b51a](0a1b51a) by [abgeorge7](https://github.com/abgeorge7) - [#34](#34) - 🐛 Bug fixes for demo - [a49a7f3](a49a7f3) by [abgeorge7](https://github.com/abgeorge7) - [#31](#31) - 💄 Added link to homepage - [3b70307](3b70307) by [abgeorge7](https://github.com/abgeorge7) - [#27](#27) - ✨ Table to show resources that reference a given ID - [4d8b934](4d8b934) by [abgeorge7](https://github.com/abgeorge7) - [#23](#23) - ♻️ Sortable table component - [c6edd6b](c6edd6b) by [abgeorge7](https://github.com/abgeorge7) - [#22](#22) - ✨ Add login screen - [d97ee30](d97ee30) by [abgeorge7](https://github.com/abgeorge7) - [#21](#21) - 💄 Adding list view toggle to homepage - [71f5ec1](71f5ec1) by [abgeorge7](https://github.com/abgeorge7) - [#20](#20) - Add auth headers to requests - [2e34aa6](2e34aa6) by [abgeorge7](https://github.com/abgeorge7) - [#17](#17) - 💄 Update tiles based on feedback - [da0e077](da0e077) by [abgeorge7](https://github.com/abgeorge7) - [#15](#15) - ✨ Ontology landing page - [ffcb194](ffcb194) by [abgeorge7](https://github.com/abgeorge7) - [#13](#13) - ⚡️ Enabling caching - [15e492f](15e492f) by [abgeorge7](https://github.com/abgeorge7) - [#12](#12) - 📝 Updating README - [0db05ca](0db05ca) by [abgeorge7](https://github.com/abgeorge7) - [#11](#11) - 📝 Documentation for best practices and design - [d244daf](d244daf) by [abgeorge7](https://github.com/abgeorge7) - [#10](#10) - ✨ Table on resource details page - [15a02b3](15a02b3) by [abgeorge7](https://github.com/abgeorge7) - [#3](#3) - ✨ Dashboard V1 - [7393e33](7393e33) by [abgeorge7](https://github.com/abgeorge7)
## Release 0.1.0 ### Summary - Emojis: 🐛 x6, ♻️ x7, ✨ x13, 💄 x5, 👷 x3, ✅ x5, 🐳 x1, 🥅 x1, ⚡️ x1, 📝 x2, ? x1 - Categories: Fixes x7, Other Changes x19, Additions x13, Ops x4, Documentation x2 ### New features and changes - [#98](#98) - 🐛 Removing duplicate codes and queries from resource details - [e5ac675](e5ac675) by [abgeorge7](https://github.com/abgeorge7) - [#97](#97) - ♻️ Adding in links to reference table - [01bdaad](01bdaad) by [abgeorge7](https://github.com/abgeorge7) - [#96](#96) - ♻️ Rearranging tabs on an ID detail page - [2f3b5ca](2f3b5ca) by [abgeorge7](https://github.com/abgeorge7) - [#95](#95) - ✨ Add Patient tab to attributes details page - [99652d0](99652d0) by [abgeorge7](https://github.com/abgeorge7) - [#94](#94) - 💄 Additional class to header - [5349bfe](5349bfe) by [abgeorge7](https://github.com/abgeorge7) - [#90](#90) - ✨ Submit Patient data feature - [be740a2](be740a2) by [abgeorge7](https://github.com/abgeorge7) - [#88](#88) - 👷 Add GH release workflow - [698ec2c](698ec2c) by [znatty22](https://github.com/znatty22) - [#87](#87) - ✨ Add Timeline to Patient resource - [3fde5b9](3fde5b9) by [abgeorge7](https://github.com/abgeorge7) - [#83](#83) - 👷 Deploy dashboard to production - [e49ddde](e49ddde) by [znatty22](https://github.com/znatty22) - [#78](#78) - ✅ Add server tests - [1e7296a](1e7296a) by [abgeorge7](https://github.com/abgeorge7) - [#77](#77) - ✅ Add attribute details page tests - [f3158f8](f3158f8) by [abgeorge7](https://github.com/abgeorge7) - [#76](#76) - ✅ Add resource details/chart page tests - [2f0041e](2f0041e) by [abgeorge7](https://github.com/abgeorge7) - [#75](#75) - ✅ Add resource ID details tests - [ddb4d62](ddb4d62) by [abgeorge7](https://github.com/abgeorge7) - [#73](#73) - ✅ Add Homepage tests - [b100edb](b100edb) by [abgeorge7](https://github.com/abgeorge7) - [#72](#72) - ♻️ Dashboard redesign - [9189ead](9189ead) by [abgeorge7](https://github.com/abgeorge7) - [#71](#71) - 🐛 Adding statement to update table when props change - [9488860](9488860) by [abgeorge7](https://github.com/abgeorge7) - [#69](#69) - 🐛 Use id instead of resource name for $snapshot - [c014781](c014781) by [abgeorge7](https://github.com/abgeorge7) - [#66](#66) - 👷 Tag docker img with git commit hash - [a648b0d](a648b0d) by [znatty22](https://github.com/znatty22) - [#65](#65) - 🐳 Dockerize the app - [dade57e](dade57e) by [znatty22](https://github.com/znatty22) - [#63](#63) - ♻️ Use $snapshot endpoint - [87dc929](87dc929) by [abgeorge7](https://github.com/abgeorge7) - [#59](#59) - ♻️ Refactoring reducers and server configuration - [4de0597](4de0597) by [abgeorge7](https://github.com/abgeorge7) - [#58](#58) - ✨ Configuration UI for adding/updating a server - [3379974](3379974) by [abgeorge7](https://github.com/abgeorge7) - [#50](#50) - 🥅 Error handling - [90fa22f](90fa22f) by [abgeorge7](https://github.com/abgeorge7) - [#49](#49) - 💄 JSON payloads are formatted on details view - [2534382](2534382) by [abgeorge7](https://github.com/abgeorge7) - [#47](#47) - ♻️ Updating app name in package.json - [8d00515](8d00515) by [abgeorge7](https://github.com/abgeorge7) - [#46](#46) - ✨ All tables are searchable - [d58f683](d58f683) by [abgeorge7](https://github.com/abgeorge7) - [#44](#44) - 🐛 Removed values with no data from bar charts - [52dbd76](52dbd76) by [abgeorge7](https://github.com/abgeorge7) - [#41](#41) - ✨ Clicking on a chart sector shows table of resources where attribute = selected value - [834a5bc](834a5bc) by [abgeorge7](https://github.com/abgeorge7) - [#40](#40) - 🐛 Adding spinner to Ontology page - [a7793d6](a7793d6) by [abgeorge7](https://github.com/abgeorge7) - [#37](#37) - ✨ References include resources referenced by the given ID - [8a364e7](8a364e7) by [abgeorge7](https://github.com/abgeorge7) - [#35](#35) - ✨ Charts show extensions - [0a1b51a](0a1b51a) by [abgeorge7](https://github.com/abgeorge7) - [#34](#34) - 🐛 Bug fixes for demo - [a49a7f3](a49a7f3) by [abgeorge7](https://github.com/abgeorge7) - [#31](#31) - 💄 Added link to homepage - [3b70307](3b70307) by [abgeorge7](https://github.com/abgeorge7) - [#27](#27) - ✨ Table to show resources that reference a given ID - [4d8b934](4d8b934) by [abgeorge7](https://github.com/abgeorge7) - [#23](#23) - ♻️ Sortable table component - [c6edd6b](c6edd6b) by [abgeorge7](https://github.com/abgeorge7) - [#22](#22) - ✨ Add login screen - [d97ee30](d97ee30) by [abgeorge7](https://github.com/abgeorge7) - [#21](#21) - 💄 Adding list view toggle to homepage - [71f5ec1](71f5ec1) by [abgeorge7](https://github.com/abgeorge7) - [#20](#20) - Add auth headers to requests - [2e34aa6](2e34aa6) by [abgeorge7](https://github.com/abgeorge7) - [#17](#17) - 💄 Update tiles based on feedback - [da0e077](da0e077) by [abgeorge7](https://github.com/abgeorge7) - [#15](#15) - ✨ Ontology landing page - [ffcb194](ffcb194) by [abgeorge7](https://github.com/abgeorge7) - [#13](#13) - ⚡️ Enabling caching - [15e492f](15e492f) by [abgeorge7](https://github.com/abgeorge7) - [#12](#12) - 📝 Updating README - [0db05ca](0db05ca) by [abgeorge7](https://github.com/abgeorge7) - [#11](#11) - 📝 Documentation for best practices and design - [d244daf](d244daf) by [abgeorge7](https://github.com/abgeorge7) - [#10](#10) - ✨ Table on resource details page - [15a02b3](15a02b3) by [abgeorge7](https://github.com/abgeorge7) - [#3](#3) - ✨ Dashboard V1 - [7393e33](7393e33) by [abgeorge7](https://github.com/abgeorge7)
Closes #18
Click on a row from the details table will produce an additional table that shows which resources reference the given ID.