Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"compile all tabs" command #22

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

ChuckJonas
Copy link

Added command to compile all open tabs.

joeferraro/MavensMate#849

@ChuckJonas
Copy link
Author

@kidtsunami any thoughts around this one? This is pretty much the only reason I ever have to switch back to sublime (when refactoring multiple dependent classes).

@kidtsunami
Copy link
Owner

@ChuckJonas yeah, just was curious why you had the workaround "getOpenEditors" vs just using visibleTextEditors

On top of that, we're upgrading the extension to use TS 2.0 and the latest VSCode version (otherwise it was failing tests and I was not confident in pushing any latest projects).

@ChuckJonas
Copy link
Author

ChuckJonas commented Apr 25, 2017

@kidtsunami That's what I thought at first but visibleTextEditors doesn't return all the open editors. Instead it just returns the editor that is currently being shown to the user (multiple if you have split panels; also includes the output channels).

You can read more about it in my feature request (maybe upvote it as well).

It's definitely a hack but the only way to implement it for the time being.

@kidtsunami
Copy link
Owner

Thanks @ChuckJonas!! Upvoted and when I sort out the latest update to the extension, I'll merge this in!

@kidtsunami kidtsunami merged commit 3346da8 into kidtsunami:master Jun 19, 2017
@kidtsunami
Copy link
Owner

This is live with v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants