[RHPAM-4889] - adjustments to make it easier to consume from openshift env vars #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication.
|
@mareknovotny can you help me understanding the checks failure? |
these errors come as dependencies are wrongly downloaded imo. Therefore for continued build there are compilation errors. I can see this error for the first time. We need to try to re-run this to see if it shows again. jenkins retest this please |
|
so this CI PR repository is now green, GHA checks have some problems with installing of dependencies from sources, not related. Trigerring FDB to also see downstream is ok with this change. |
|
@mareknovotny FDB has failed, but doesn't look like it’s related to the changes |
|
it is not a problem with the PR, but with those artifacts from google which are proxied in internal Nexus Maven Repository, it seems they were downloaded, but not correctly or fully. Therefore those compilation errors and ZIP end headers missing in errors. |
|
jenkins do fdb |
|
@mareknovotny thx for the update! |
|
ok, now FDB green too. Please add backport labels if this need to be on supported branches too 7.67.x and 7.67.x-blue ;) |
tomasdavidorg
approved these changes
Feb 26, 2024
...-backend/src/main/java/org/jbpm/workbench/ks/integration/KieServerQueryDefinitionLoader.java
Show resolved
Hide resolved
mareknovotny
approved these changes
Mar 26, 2024
mareknovotny
changed the title
|
jenkins retest this please |
|
jenkins do fdb |
1 similar comment
|
jenkins do fdb |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…t env vars (#1607) * RHPAM-4889: using a feature flag to enable/disable strict mode. (#1606) * RHPAM-4889: using a feature flag (jbpm.wb.querymode values DEFAULT or STRICT) to enable/disable strict mode. by default it'll continue behave as before this change. * RHPAM-4889: reducing duplication. * RHPAM-4889: adjustments to make it easier to consume from openshift env vars * to solve @tomasdavidorg review comment --------- Co-authored-by: Marek Novotný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request
JIRA: (please edit the JIRA link if it exists)
RHPAM-4889
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.