DROOLS-7618 : Project Editor: Long description should not freeze the UI #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins do fdb |
|
@Rikkola As we discuss, these 3 points need to be fixed:
|
tomasdavidorg
suggested changes
May 27, 2024
| @@ -205,6 +210,16 @@ Promise<Boolean> validateStringIsNotEmpty(final String string, | |||
| }); | |||
| } | |||
|
|
|||
| private Promise<Object> validateDescriptionLength() { | |||
| return promises.create((resolve, reject) -> { | |||
| if(pom.getDescription() != null && pom.getDescription().length() > 3000){ | |||
There was a problem hiding this comment.
Could you please replace the value to with a constant? For example MAX_DESCRIPTION_LENGTH.
|
@tomasdavidorg Ok. War zip updated as is the PR. |
tomasdavidorg
approved these changes
Jun 6, 2024
|
jenkins do fdb |
mareknovotny
pushed a commit
that referenced
this pull request
Jun 25, 2024
…UI (#3825) (#3826) Co-authored-by: Toni Rikkola <[email protected]>
akumar074
pushed a commit
to akumar074/kie-wb-common
that referenced
this pull request
Jul 11, 2024
…UI (kiegroup#3825) (cherry picked from commit cbb4803)
akumar074
added a commit
that referenced
this pull request
Jul 18, 2024
…UI (#3825) (#3827) (cherry picked from commit cbb4803) Co-authored-by: Toni Rikkola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: DROOLS-7618
Business Central: WAR file
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.