Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin viewport in clipped diagram while applying new layout data #56

Open
sailingKieler opened this issue Jul 16, 2020 · 0 comments
Open

Pin viewport in clipped diagram while applying new layout data #56

sailingKieler opened this issue Jul 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@sailingKieler
Copy link
Member

sailingKieler commented Jul 16, 2020 •
edited
Loading

If the diagram drawing is clipped to the child area of a (nested) compound diagram node, and a subsequent layout run determines new coordinates for current clip node (or for some of its transitive parents) the viewport of the main diagram window appears to jump away, see

first layout (main diagram on the right):
Bildschirmfoto 2020-07-16 um 16 46 38

second layout:
Bildschirmfoto 2020-07-16 um 16 47 51

The truth is, that the viewport stays in place as revealed by the outline (on the left), whereas position vector of the clip node changed, and with that the accumulated position vectors of the child nodes shown in the main diagram.
This issue demands for a smart update of the viewports position vector yielding a stable position of the viewport in relation to the current clip node during the application of diagram layout data.
@sailingKieler sailingKieler added the enhancement New feature or request label Jul 16, 2020
sailingKieler added a commit that referenced this issue Dec 16, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
4e43734 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped daigrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions in the zooming, the clipping functionality itself, the outline, and the magnifier lens
sailingKieler added a commit that referenced this issue Dec 16, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
fa22bc3 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions in the zooming, the clipping functionality itself, the outline, and the magnifier lens
sailingKieler added a commit that referenced this issue Dec 16, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
35571e1 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
sailingKieler added a commit that referenced this issue Dec 16, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
ebbe39b 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
@sailingKieler sailingKieler mentioned this issue Dec 16, 2021
Merged
sailingKieler added a commit that referenced this issue Dec 21, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
b602a2b 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
sailingKieler added a commit that referenced this issue Dec 22, 2021
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
bd14100 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
sailingKieler added a commit that referenced this issue Feb 11, 2022
@sailingKieler
klighd.piccolo: important change in the drawing coordinate system app…
c90053f 
…lication, solves #56

* now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances;
* updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sailingKieler