Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable customization of ToolTip in diagram browser #73

Closed
sailingKieler opened this issue Oct 26, 2020 · 3 comments
Closed

Enable customization of ToolTip in diagram browser #73

sailingKieler opened this issue Oct 26, 2020 · 3 comments
Assignees
@sailingKieler
Labels
enhancement New feature or request

Comments

@sailingKieler
Copy link
Member

The tooltip implementation is currently hard-coded in PiccoloViewer.

A client raised the question for enabling some customization instead of this hard-wiring.
@sailingKieler sailingKieler added the enhancement New feature or request label Oct 26, 2020
@sailingKieler sailingKieler self-assigned this Oct 26, 2020
sailingKieler added a commit that referenced this issue Oct 26, 2020
@sailingKieler
klighd.piccolo: enabled installation of customized tooltip renderer i…
f99eac0 
…n sub classes of 'PiccoloViewer', as demanded in #73
sailingKieler added a commit that referenced this issue Jan 28, 2021
@sailingKieler
klighd.piccolo: enabled installation of customized tooltip renderer i…
5c31b1a 
…n sub classes of 'PiccoloViewer', as demanded in #73
@NiklasRentzCAU
Copy link
Member

NiklasRentzCAU commented Jul 28, 2021 •
edited
Loading

I am currently cleaning up some of the older tickets - this one seems to be done already, can it be closed @sailingKieler?

Edit: Just noticed, the commits for fixing this are not yet on the master branch, I guess we would need that first to close this.

@sailingKieler
Copy link
Member Author

Edit: Just noticed, the commits for fixing this are not yet on the master branch, I guess we would need that first to close this.

Seems to be the case. I don't have an overview over the various branches anymore.
@NiklasRentzCAU feel free to cherry pick the relevant change and push it to master.

NiklasRentzCAU pushed a commit that referenced this issue Aug 16, 2021
@sailingKieler @NiklasRentzCAU
klighd.piccolo: enabled installation of customized tooltip renderer i…
580b3a1 
…n sub classes of 'PiccoloViewer', as demanded in #73
@NiklasRentzCAU
Copy link
Member

Cherry-picked to master, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sailingKieler sailingKieler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sailingKieler @NiklasRentzCAU