Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor improvements #153

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Some minor improvements #153

merged 3 commits into from
Mar 6, 2023

Conversation

sailingKieler
Copy link
Member

Some minor improvements, mainly for developing.

@NiklasRentzCAU, @soerendomroes, @a-sr would that cause any issues for you?

@sailingKieler sailingKieler added the enhancement New feature or request label Jan 9, 2023
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know much about the Eclipse UI stuff, so I cannot say much about that. The additional optional dependency of kgraph.text to the klighd base package also includes the transitive dependency to the swt stuff is not as nice, but given the structure of the project it is fine I guess, no objections.

@sailingKieler sailingKieler merged commit 9b231e1 into master Mar 6, 2023
@NiklasRentzCAU
Copy link
Member

@sailingKieler Turns out, I now do have an objection about one of the changes here, specifically with the commit 286bdab: The changes in KGraphResource break KGraphs with the "de.cau.cs.kieler.kgraphsynthesis.defaults" set. As an example, this model will not synthesize with defaults on, although they are set to "As in Model" in the synthesis:

properties: 
  de.cau.cs.kieler.kgraphsynthesis.defaults=true

knode n

For a quick fix I already tried just adding this property back in in the file, however that did not fix the problem. Reverting the commit fixed it for me again.
Can you please elaborate what the changes in that commit do and do you have an idea how we might fix the issue again with your modification without just reverting the commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants