[Build] Fix build plugin version warnings and build with Maven 3.9.9 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the most recent versions of Maven these warnings are now errors
|
Github does not consider the changes in workflows in verification builds of PRs created by non-committers, so the verification does not test this. |
NiklasRentzCAU
requested changes
Oct 21, 2024
Comment on lines
+30
to
+33
| - name: Set up Maven | ||
| uses: stCarolas/setup-maven@d6af6abeda15e98926a57b5aa970a96bb37f97d1 # v5 | ||
| with: | ||
| maven-version: 3.9.9 |
There was a problem hiding this comment.
I would like to update the Maven version via using Java 21 in the setup-java task as the default build Java version transitively instead of introducing a new third-party GH action dependency here. Is there any reason to switch from the Maven version that is shipped with setup-java right now to justify doing this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recent versions of Maven these warnings are now errors