Add container property to ElkEdge
#209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ELK#775](eclipse/elk#775) added a `container` property to edges: > Write a container property into each edge after layout. This gives the id of the node that was this edge's container, and helps the user interpret the route points in the right coord system. Updating the `ElkEdge` type to reflect this and avoid type errors
|
Thank you for this PR. We are in the process of improving the container property. I am however currently ill and so do not feel alarmed if it takes a while. |
|
Thank you, I appreciate that and all the work you've put into this library! I hope you feel better! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELK#775 added a
containerproperty to edges:Updating the
ElkEdgetype to reflect this and avoid type errors.Note to reviewers: not sure if this type belongs in
ElkEdge, orElkExtendedEdge. Based on the upstream PR, I think this should be a non-optional property but happy to make changes!