Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hideous layout for text options #10

Closed
christoph-fricke opened this issue Aug 5, 2021 · 0 comments · Fixed by #11
Closed

Hideous layout for text options #10

christoph-fricke opened this issue Aug 5, 2021 · 0 comments · Fixed by #11
Assignees
@christoph-fricke
Labels
bug Something isn't working

Comments

@christoph-fricke
Copy link
Contributor

Text options rendered in the options sidebar look rather hideous. Their input field and label are next to each other. Instead, the label text should be above the input. Similar to range options. Furthermore, the input fields could use a bit of theming. They do not work well with a dark theme in VS Code.

Example screenshot is provided by the OSGiViz VS Code extension:

image
@christoph-fricke christoph-fricke self-assigned this Aug 5, 2021
@christoph-fricke christoph-fricke added the bug Something isn't working label Aug 5, 2021
christoph-fricke added a commit that referenced this issue Aug 12, 2021
@christoph-fricke
fix(core): text inputs should use a vertical layout
76328ff 
refs: #10
christoph-fricke added a commit that referenced this issue Aug 12, 2021
@christoph-fricke
feat(core): add theming for text inputs
3ebc014 
refs: #10
@christoph-fricke christoph-fricke mentioned this issue Aug 12, 2021
Merged
christoph-fricke added a commit that referenced this issue Aug 16, 2021
@christoph-fricke
Merge pull request #11 from kieler/cfr/input-option
58bc4ba 
Core: Fix layout used by text input options (#10)
NiklasRentzCAU added a commit that referenced this issue Nov 8, 2021
@NiklasRentzCAU
CI: fixing npm publish #10
e4d96bf
NiklasRentzCAU added a commit that referenced this issue Nov 8, 2021
@NiklasRentzCAU
CI: fixing npm publish #10
646ecf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christoph-fricke christoph-fricke

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: Fix layout used by text input options (#10) kieler/klighd-vscode
1 participant
@christoph-fricke