Reopen new diagram widget on start for current active editor. #100
Conversation
There was a problem hiding this comment.
It is very nice that it is possible to reopen the diagram on startup, albeit not using the VS Code API for that. For the SCCharts extension I can see this being the wanted behavior, as the diagrams always belong to the extension. As this is implemented here in klighd-vscode however, I would like this feature to have some slightly different behavior to avoid users that have this and an extension with very generic syntheses installed to always open (not reopen) a diagram on startup, even if they manually closed it in the previous session.
I would suggest to only restore the view when it was opened before (either via VS Code API or maybe via some persistent / session storage). Furthermore, what about this being an option to open a diagram automatically on startup or not?
I assume that the second editor group is the one of the diagram, which allows it to be placed below or beside.
Since the old webviewPanel does not refer to the old
SprottyWebview(which is aKlighdWebview) cannot be readded to the list of availableKlighdWebviews inKlighdExtensionand the old panel cannot be used during the creation of a newKlighdWebviewsince it isreadonly, we recreate the Diagram on the start of the extension for the currently active editor.