support for top-down scalefactor #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks a little bit
Comment on lines
176
to
181
| let topdownScaleFactor = 1 | ||
| if ((element.parent as any).properties == undefined || (element.parent as any).properties['org.eclipse.elk.topdown.scaleFactor'] == undefined) { | ||
| topdownScaleFactor = 1 | ||
| } else { | ||
| topdownScaleFactor = (element.parent as any).properties['org.eclipse.elk.topdown.scaleFactor'] | ||
| } |
There was a problem hiding this comment.
the scale factor already is 1, so just inverting the condition would make an else clause unnecessary. Or, why not write this as a one-liner with a fallback like this: const topdownScaleFactor = (element.parent as any).?properties['org.eclipse.elk.topdown.scaleFactor'] ?? 1
And: is this any cast necessary?
(multiple occurances of this in this PR)
There was a problem hiding this comment.
good suggestion for simplifying the code, I'll have to check the any cast
| @@ -369,6 +386,7 @@ export class DepthMap { | |||
| */ | |||
| computeDetailLevel(region: Region, viewport: Viewport, relativeThreshold: number, scaleThreshold: number): DetailLevel { | |||
| if (!this.isInBounds(region, viewport)) { | |||
| console.log(region.boundingRectangle.id + " out of bounds") | |||
There was a problem hiding this comment.
debug log or message important for the user?
There was a problem hiding this comment.
I think this was for debugging and will be removed
change == to ===
please the prettier
really please the prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding server side PR kieler/KLighD#173 but doesn't rely on it to not break things