Version Updates #162
Version Updates #162
Conversation
… and vscode-languageclient 8.0.2
…dates. Deactivate bookmark panel for now.
…ed variables to be fine.
| }, | ||
|
|
||
| node: { | ||
| net: "mock", | ||
| __dirname: 'mock', |
There was a problem hiding this comment.
inconsistent use of ' and " in this file
There was a problem hiding this comment.
Created #163 to fix this and the other formatting comments in one sweep in another PR.
| ``` | ||
|
|
||
| ### Dispatching Actions | ||
| *This feature is currently not supported* |
There was a problem hiding this comment.
does this break any of our stuff?
There was a problem hiding this comment.
This feature has not been used in any other extension, so it does not break anything either.
| } | ||
| }) | ||
| ); | ||
| } |
There was a problem hiding this comment.
missing newline at end of file
|
|
||
| extension.webviews.forEach((webview) => webview.dispatch(action)); | ||
| // TODO: this has not been tested yet if the messenging change works like this. | ||
| messenger.sendNotification({ method: "diagram/accept" }, { type: 'webview', webviewType: diagramType }, action); |
There was a problem hiding this comment.
what exactly is affected by this and what needs to be done to test whether this works?
There was a problem hiding this comment.
// Command provided for other extensions to dispatch an action if a webview is open
As this comment above suggests, this is the feature that I marked as currently not supported in the documentation. To test this we would need to use this feature in another extension, i.e. dispatch some action that should be executed from that other extension. As I don't see a use case currently, I think this is fine to document it being (potentially) not fully supported atm.
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| */ | ||
| import "reflect-metadata"; |
There was a problem hiding this comment.
inconsistent use of ' and " in this file
| await super.receiveAction(message); | ||
| await this.languageClient.sendNotification(acceptMessageType, message); | ||
| } | ||
| } |
| super.didCloseWebview(endpoint); | ||
| this.storageService.setItem('diagramOpen', false) | ||
| } | ||
| } |
| return this.root | ||
| } | ||
|
|
||
| redo(_context: CommandExecutionContext): SModelRoot { | ||
| redo(_context: CommandExecutionContext): SModelRootImpl { | ||
| return this.root | ||
| } | ||
| } |
Updates Sprotty to version 1.1.0 and alongside it now requires node 16, es2017, new webpack 5 and others.