Master Thesis - Node Scaling - Code Review #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably slightly less efficient due to eager evaluation instead of short circuiting, but easier to read
apparently parentRendering can be undefined sometimes workaround rather than fix as the field is not supposed to be undefined, so this just suppresses the symptom rather than solving the source
TODO: * hide labels, comments etc. * adjust edges * make sure not to overlap siblings
based on the comment on SKGraphElement SKNode and SKEdge should have this superclass
neither depends on the DepthMap and both operate on Region so it makes more sense to have them there also marks DepthMap fields as private and reduces type requirement from KNode to KShapeELement as that is sufficient for a Regions boundingRectangle
still require the title height to scale the node accordingly and thus require the DepthMap and thus UseSmartZoom
…imum scale" This reverts commit 5b9cb2f. This revert requires some adjustments to node scaling for that to continue working as intended # Conflicts: # packages/klighd-core/src/options/render-options-registry.ts # packages/klighd-core/src/views-rendering.tsx
also we only need to know the dimensions of the parent
Eddykasp
reviewed
Feb 23, 2022
instead of recursively forcing an update with the force flag parameter we check whether one of the input values has changed
pull the scale calculation out into its own function for easier short circuiting
this time with refactoring error fixed
Skgland
force-pushed
the
ben/node_scaling
branch
from
8fccbea
to
ffef143
Compare
Eddykasp
requested changes
Mar 17, 2022
…equal this helps when node scaling and title scaling are set to the same target scale. if a node is already scaled to the target scale the title in it should not need scaling, but due to imprecisions in floating point numbers they would attempt to scale anyway, causing a background to be added unnecessarily
…f the effective zoom
Eddykasp
reviewed
Apr 19, 2022
Eddykasp
approved these changes
May 5, 2022
# Conflicts: # packages/klighd-core/src/depth-map.ts # packages/klighd-core/src/skgraph-models.ts # packages/klighd-core/src/views-rendering.tsx # packages/klighd-core/src/views.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the review of the code produced during my master thesis