Exploring workspaces #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjoar
commented
Jun 30, 2017
platform/plugins/workspaces/index.ts
Outdated
| .first() | ||
| .toPromise(); | ||
|
|
||
| if (!workspacesConfig.enabled) { |
There was a problem hiding this comment.
(the pluginsystem doesn't handle some.config.path.enabled: false yet, but I've started on working that in locally)
kimjoar
force-pushed
the
platform/workspaces-poc
branch
6 times, most recently
from
5c38e30
to
2f759b9
Compare
kimjoar
force-pushed
the
typescript-cleanups
branch
2 times, most recently
from
5209618
to
bc6cd7a
Compare
kimjoar
force-pushed
the
platform/workspaces-poc
branch
from
2f759b9
to
e1bc744
Compare
kimjoar
pushed a commit
that referenced
this pull request
Jul 9, 2017
[no-unused-vars]: Disallow declaration of variables that are not used in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(just creating this PR so others can see what it looks like, not intended for merge)