Kimkulling/fix 2d coords

[kimkulling]

• closes 2D-Rendering: Coordinate mapping is broken #239

Summary by CodeRabbit

• New Features

  • Introduced a new red rectangle drawing operation in the demo application, enhancing the visual output.

• Bug Fixes

  • Adjusted coordinate mapping calculations to improve rendering accuracy.
  • Modified vertex index order for rectangle rendering to ensure correct display.

• Documentation

  • Updated comments in the constructor of the IRenderPath struct for clarity.

[coderabbitai]

Walkthrough

The changes introduced in this pull request include the addition of a new red rectangle drawing operation in the Demo2D.cpp file, modifications to coordinate mapping calculations in the CanvasRenderer.cpp file, and a minor update to the constructor comment in RenderCommon.h. These adjustments aim to improve the rendering of 2D graphics, specifically addressing coordinate mapping issues.

Changes

File	Change Summary
samples/02_Demo2D/Demo2D.cpp	Added a red rectangle drawing operation in Demo2DApp, covering coordinates (1, 1) to (1000, 760).
src/Engine/RenderBackend/2D/CanvasRenderer.cpp	Modified mapCoordinates for correct scaling and negated yOut. Changed vertex index order in createRectVertices.
src/Engine/RenderBackend/RenderCommon.h	Updated the constructor comment in IRenderPath to indicate an empty body.

Assessment against linked issues

Objective	Addressed	Explanation
The 2D-Canvas renderer should use the whole resolution (239)	✅
The y-coordinate origin should be at the top (239)	✅

🐇 In the land of code where rabbits play,
A red rectangle hops in to brighten the day.
With coordinates fixed and the canvas in line,
Our rendering's better, oh how it will shine!
So let’s celebrate this change with a cheer,
For a smoother display, we’ve nothing to fear! 🥕

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c04022 and 4f0a6ec.

Files selected for processing (3)

• samples/02_Demo2D/Demo2D.cpp (1 hunks)
• src/Engine/RenderBackend/2D/CanvasRenderer.cpp (2 hunks)
• src/Engine/RenderBackend/RenderCommon.h (1 hunks)

Files skipped from review due to trivial changes (1)

• src/Engine/RenderBackend/RenderCommon.h

Additional comments not posted (3)

samples/02_Demo2D/Demo2D.cpp (1)

86-88: Consider using dynamic values for the rectangle dimensions.

The hardcoded dimensions of the red rectangle (1, 1, 1000, 760) might cause rendering issues if the application window size changes. Consider using dynamic values based on the application window size to ensure the rectangle is rendered correctly regardless of the window size.

Please verify if this change addresses the coordinate mapping issues mentioned in the PR objectives, specifically:

1. Improper use of render screen
2. Y-mapping issues
3. Y-coordinate origin

It's unclear how adding a new rectangle drawing operation resolves these issues. If this change is not directly related to the PR objectives, consider moving it to a separate PR to keep the changes focused and maintainable.

Run the following script to verify the PR objectives:

src/Engine/RenderBackend/2D/CanvasRenderer.cpp (2)

59-61: Verify the correctness and impact of the coordinate mapping changes.

The changes in the mapCoordinates function will affect how the input coordinates are mapped to the model space. Key observations:

1. The input coordinates are now multiplied by 2.0 before division, which will change the scaling of the mapped coordinates.
2. The output for yOut is negated, which will invert the y-coordinate and flip the rendered output vertically.

Please ensure that these changes align with the expected behavior and do not introduce any unintended side effects.

---

353-358: Verify the correctness and impact of the index order changes.

The changes in the createRectVertices function modify the order of indices for rendering rectangles. Key observations:

1. The indices for the first triangle of the rectangle have been swapped.
2. The second and third indices have been interchanged, as well as the fifth and sixth indices.

Changing the index order will affect how the rectangle is rendered by altering the vertex order. This could potentially change the facing direction of the triangles.

Please ensure that these changes produce the desired rendering output and do not introduce any visual artifacts or incorrect geometry.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.