Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WindowDoorSensor #52

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

derjoerg
Copy link
Contributor

This implements the Window Door Sensor

@derjoerg
Copy link
Contributor Author

I don't know how to fix the test-problem here.
This device has only one pairing and this affects the state.
If I remove the "not covered" Return False, I get a problem with ruff, if I leave it in I get a problem with the test 😢

@kingsleyadam
Copy link
Owner

I don't know how to fix the test-problem here. This device has only one pairing and this affects the state. If I remove the "not covered" Return False, I get a problem with ruff, if I leave it in I get a problem with the test 😢

You can also just add a dummy output (AL_INVALID?)

@kingsleyadam kingsleyadam merged commit 7ad31b9 into kingsleyadam:main Oct 18, 2024
2 checks passed
@kingsleyadam kingsleyadam added the enhancement New feature or request label Oct 18, 2024
@kingsleyadam
Copy link
Owner

Let me know if you need to me to cut a release, I'll hold off until we're ready to implement into Home Assistant.

@derjoerg
Copy link
Contributor Author

derjoerg commented Oct 18, 2024

Let me know if you need to me to cut a release, I'll hold off until we're ready to implement into Home Assistant.

Will do. I have some more - low hanging fruits - device classes I want to implement

  • Door Bell
  • Temperature Sensor
  • Wind Sensor
  • Rain Sensor

before I dive into to HA development 😃

Later on I will also contribute:

  • RTC
  • Shutter

But they look a bit more complex

@derjoerg derjoerg deleted the WindowDoorSensor branch October 18, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants