-
Notifications
You must be signed in to change notification settings - Fork 81
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do partial revert of previous commit; gmsh-sdk not working in travis
- Loading branch information
Showing
1 changed file
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87363ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is disappointing. I had been hoping that gmsh-sdk would be a smooth way forward, enabling use.of the Gmsh Python API #180. I can't seem to get.to the Travis CI report from here. I'll try from the desktop tomorrow.
I wonder could it be something like apt-installing gmsh bringing in some dependencies which the binary gmsh installed by gmsh-sdk also requires but doesn't install. I might not notice this on my desktop as I already have those libraries installed for other reasons.
87363ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, gmsh-sdk is licensed under GPL so I'm not willing to import it in the main library.
87363ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not an issue to have a separate GPL-licensed file under skfem.io, though. I need to think about it.