Add MeshTet.init_ball #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! init_ball is very clever and very useful. May I ask whether you came up with this trick or where you found it? I'm not sure about the triaxial scaling though. It might be better to change the example to the special case of the sphere—until we have some kind of tetrahedral smoother or optimizer. Are the elements quite pointy? I look forward to sketching out the action of init_ball when I get back to the desk and pencil and paper. A sphere would be fine anyway for demonstrating the effectiveness of the block diagonal preconditioner. |
|
I think I learned it from @ahhuhtal like 6 years ago but I'm not completely
sure. The shape of the elements can be an issue but at least the test seems
to pass. Not sure how strict the bounds are in this case.
|
|
@gdmcbain will you make a new PR when it's ready? |
don't stretch ball
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gdmcbain you think this closes #490 ?