Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for the next release #738

Merged
merged 31 commits into from
Sep 17, 2021
Merged

Preparation for the next release #738

merged 31 commits into from
Sep 17, 2021

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented Sep 12, 2021

@kinnala
Copy link
Owner Author

kinnala commented Sep 13, 2021

ex40_skeleton

@kinnala kinnala mentioned this pull request Sep 14, 2021
@kinnala
Copy link
Owner Author

kinnala commented Sep 15, 2021

ex41_solution

@kinnala kinnala changed the title Various fixes Preparation for the next release Sep 15, 2021
@kinnala
Copy link
Owner Author

kinnala commented Sep 15, 2021

Again a quite large PR (sorry for that) but @gdmcbain if you have any general suggestions I'm happy to hear those.

@kinnala
Copy link
Owner Author

kinnala commented Sep 15, 2021

Oh, one thing that's missing is a test for #733.

@gdmcbain
Copy link
Contributor

On demonstrating and testing the TrilinearForm #733, I wondered when I first heard about it whether it would be applicable to the Newton-linearized linear and bilinear forms arising from the trilinear advective term in the Navier‐Stokes equations.

@LinearForm
def acceleration(v, w):

return np.einsum('j...,ij...,i...', w['wind'], grad(w['wind']), v)

@BilinearForm
def acceleration_jacobian(u, v, w):

return dot(np.einsum('j...,ij...->i...', w['wind'], grad(u))
+ np.einsum('j...,ij...->i...', u, grad(w['wind'])), v)

but I haven't looked into it.

@gdmcbain
Copy link
Contributor

One thing that might be good soon is an example demonstrating spatial periodicity. #688 Though there is already tests.test_manufactured.test_periodic_mesh_assembly.

gdmcbain
gdmcbain approved these changes Sep 16, 2021
docs/examples/ex22.py Show resolved Hide resolved
docs/examples/ex41.py Outdated Show resolved Hide resolved
skfem/assembly/form/bilinear_form.py Outdated Show resolved Hide resolved
docs/examples/ex40.py Show resolved Hide resolved
@kinnala
Copy link
Owner Author

kinnala commented Sep 17, 2021

On demonstrating and testing the TrilinearForm #733, I wondered when I first heard about it whether it would be applicable to the Newton-linearized linear and bilinear forms arising from the trilinear advective term in the Navier‐Stokes equations.

Probably yes but it's a bit unclear to me when and how the sparse 3-tensor contraction can be done efficiently. See #733 and the linked discussion for more info. However, I can see that for some dimensions this can be a feasible approach. In UQ I think you may have a huge number of material fields already in the beginning, e.g., if doing Monte Carlo.

@kinnala
Copy link
Owner Author

kinnala commented Sep 17, 2021

ex42_solution
@gdmcbain I used your example almost verbatim. I hope you don't mind.

@kinnala kinnala merged commit 237e55c into master Sep 17, 2021
@kinnala kinnala deleted the side-default-params branch September 17, 2021 11:41
@gdmcbain
Copy link
Contributor

Sure. It's simple and gives an immediate visual display of periodicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElementTriDG.dofnames is incorrect Add TrilinearForm Assemble inverse mixed meshes
2 participants