Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: provide useful errors when process_lib versions mismatch #227

Conversation

nick1udwig
Copy link
Collaborator

Problem

Resolves #220

Solution

Check process_lib versions and, if they don't match, error out with a helpful error message.

Docs Update

None

Notes

Error looks like:

$ kit b --force
ERROR src/main.rs:1195: 
   0: Found different versions of kinode_process_lib in different crates:
      ^0.8.5	["my_lib"]
      ^0.9.0	["foo", "bar", "baz", "lol", "rofl"]

Location:
   src/build/mod.rs:393

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: kit::build::check_process_lib_version
      at src/build/mod.rs:380
   1: kit::build::execute
      at src/build/mod.rs:1275

Suggestion: Set all kinode_process_lib versions to be the same to avoid hard-to-debug errors.

@nick1udwig nick1udwig merged commit bfe15d1 into v0.7.2 Sep 5, 2024
@nick1udwig nick1udwig deleted the hf/provide-useful-errors-w-mismatched-process_lib-versions branch September 5, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant