Internal changes looking to LAS 3.0 support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some more radical behind the scenes changes, basically abandoning dicts internally in favour of a list subclass that also provides some limited access as a mapping. Much better for LAS 3.
Update attributes.ipynb and attributes.ipynb scratch.ipynb -> notebooks/build LAS file from scratch.ipynb unwrapped.ipynb -> notebooks/converting LAS file with wrapped data to unwrapped.ipynb spreadsheet.ipynb to Excel.ipynb
(which implements sections as a combined sequence + mapping type) duplication.ipynb mnemonic_duplicate-Copy1.ipynb mnemonic_duplicate.ipynb
All tests passing including those for issue #105 Basic tests on the combined list & mapping SectionItems type are not yet written. mnemonic_duplicate-Copy1.ipynb -> notebooks/issues/PR #106 - test mnemonic_missing_multiple.ipynb sample_issue105_a.ipynb sample_issue105_b.ipynb notebooks/issues/sample_write_sect_widths_20_narrow.ipynb notebooks/issues/sample_write_sect_widths_20_wide.ipynb notebooks/issues/test_df_curve_addition_on_export.ipynb
You can now directly assign values to HeaderItems - see the tutorial notebooks. attributes.ipynb -> notebooks/basic example of reading a LAS file.ipynb LAS file.ipynb
Needs some rigorous thinking and work on LASFile.__setattr__ and __getattr__ and __setitem__ and __getitem__ in order to be able to cope with LAS 3.0 Nearly there - and then tests.
This was referenced Feb 1, 2016
kinverarity1
added a commit
that referenced
this pull request
Feb 2, 2016
Internal changes looking to LAS 3.0 support
|
New aspects:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing sections internally from OrderedDicts to lists, where some access as a map is implemented in a list subclass (SectionItems).
Passing basic tests but a lot still to clean up.