Parse comma-delimited ~ASCII sections #265 #485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Parse comma-delimited ~ASCII sections #265. This is primarily for parsing the data section of LAS-3.0 files. It should work for LAS-3.0 files using the standard Curves, Parameter, and ASCII sections and for LAS-3.0 files using the Log_Definition, Log_Parameter and Log_Data sections.
Change Details:
function based on the identified data delimiter. This works for
the normal engine. The numpy engine still needs work
provisional_delimter is fully defined.
after initial scan of the las file the original data_section_inidices
is empty and las3_data_section_indicies is populated
reader.read_data_section_iterative_normal_engine()
Notes:
I left these changes out of this specific pull-request. They can be implemented in future pull-requests
Test-Results
All tests pass.
One of the LAS-3.0 tests is updated to reflect that the change will store a LAS-3.0
~Log_Definition
sections data in Lasio'sCurve
section and the LAS-3.0's~Log_Parameter
section in Lasio'sParameter
section.--
Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.
Thank you,
DC