Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict template checks #2711

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Enable strict template checks #2711

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6827ef4
Change angularCompilerOptions to use strictTemplates
mark-drastrup Jan 2, 2023
b31029b
Fix TS errors
mark-drastrup Jan 2, 2023
00e0c85
Revert "Fix TS errors"
mark-drastrup Jan 2, 2023
b8bafd6
disable strictDomEventTypes and redo fix of TS errors
mark-drastrup Jan 2, 2023
fde2c09
Merge branch 'develop' into enhancement/1985-enable-strict-template-c…
mark-drastrup Jan 17, 2023
927f85d
Merge branch 'develop' into enhancement/1985-enable-strict-template-c…
mark-drastrup Jan 25, 2023
739f9b6
Remove any type casting from templates
mark-drastrup Feb 1, 2023
313c483
Merge branch 'develop' into enhancement/1985-enable-strict-template-c…
mark-drastrup Feb 1, 2023
b72f537
Merge branch 'develop' into enhancement/1985-enable-strict-template-c…
mark-drastrup Feb 23, 2023
ecadcb3
Merge branch 'develop' into enhancement/1985-enable-strict-template-c…
mark-drastrup Feb 23, 2023
246fb02
Fix strict template error
mark-drastrup Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/designsystem/src/lib/components/list/list-item/list-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class ListItemComponent implements OnInit, AfterViewInit {

@Input() item: any;

@Input() boundaryClass: BoundaryClass;
@Input() boundaryClass: BoundaryClass | BoundaryClass[];

@Input() swipeActions: ListSwipeAction[] = [];

Expand Down
3 changes: 2 additions & 1 deletion libs/designsystem/src/lib/components/modal/alert/alert.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
import { Observable, of } from 'rxjs';

import { WindowRef } from '../../../types/window-ref';
import { ThemeColor } from '../../../helpers';

@Component({
selector: 'kirby-alert',
Expand Down Expand Up @@ -36,7 +37,7 @@ export class AlertComponent implements AfterViewInit {
}

@Input() iconName: string;
@Input() iconThemeColor: string;
@Input() iconThemeColor: ThemeColor;
@Input() okBtn: string;
@Input() okBtnIsDestructive: boolean;
@Input() cancelBtn: string;
Expand Down
10 changes: 5 additions & 5 deletions ...esignsystem/src/lib/components/page-local-navigation/page-local-navigation.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@
[attr.aria-label]="badge.description"
[themeColor]="badge.themeColor"
>
<ng-container *ngIf="badge.content.name; else badgeTextContent">
<ng-container *ngIf="$any(badge).content.name; else badgeTextContent">
mark-drastrup marked this conversation as resolved.
Show resolved Hide resolved
<kirby-icon
*ngIf="badge.content.isCustom; else defaultIconName"
[customName]="badge.content.name"
*ngIf="$any(badge).content.isCustom; else defaultIconName"
[customName]="$any(badge).content.name"
></kirby-icon>
<ng-template #defaultIconName>
<kirby-icon [name]="badge.content.name"></kirby-icon>
<kirby-icon [name]="$any(badge).content.name"></kirby-icon>
</ng-template>
</ng-container>
<ng-template #badgeTextContent>
{{ badge.content.text }}
{{ $any(badge).content.text }}
</ng-template>
</kirby-badge>
</ng-container>
Expand Down
2 changes: 1 addition & 1 deletion libs/designsystem/src/lib/components/reorder-list/reorder-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class ReorderListComponent implements OnChanges, OnDestroy {

private setupDomListener() {
const callback = (mutationsList: any) => {
for (let mutation of mutationsList) {
for (const mutation of mutationsList) {
if (mutation.oldValue !== mutation.target['className']) {
this.reorderActive = mutation.target['className'].includes('reorder-list-active');
}
Expand Down
2 changes: 1 addition & 1 deletion libs/designsystem/src/lib/components/segmented-control/segmented-control.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
>
<ng-container *ngIf="item.badge.icon; else badgeContent">
<kirby-icon
*ngIf="item.badge.isCustomIcon; else defaultIconName"
*ngIf="$any(item).badge.isCustomIcon; else defaultIconName"
mark-drastrup marked this conversation as resolved.
Show resolved Hide resolved
[customName]="item.badge.icon"
></kirby-icon>
<ng-template #defaultIconName>
Expand Down
3 changes: 2 additions & 1 deletion libs/designsystem/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"annotateForClosureCompiler": true,
"skipTemplateCodegen": true,
"strictMetadataEmit": true,
"fullTemplateTypeCheck": true,
"strictTemplates": true,
"strictDomEventTypes": false,
Copy link
Contributor Author

@mark-drastrup mark-drastrup Jan 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled strictDomEventTypes because it throws an error each time we try to access a property on a DOM event. Fx:

<input (change)="onChange($event.target.value)" />

All events are typed as a generic Event, which doesn't allow us to access $event.detail.checked or $event.target.value, which we do in many components. I did initially handle it by passing the event to the method and do the typing in there. That solution was a bit cumbersome, especially when doing it for Ionic events, that needs to be handled like this:

import { ItemReorderEventDetail } from '@ionic/angular';

doReorder(event: Event) {
  const customEvent = event as CustomEvent<ItemReorderEventDetail>;
  // replace event usages with customEvent
}

Since we have to type cast the event in the method, I think we lose the value of type checking the input in the template.

"strictInjectionParameters": true,
"enableResourceInlining": true,
"inlineSourceMap": true,
Expand Down