Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: prepare release of extensions-angular #3621

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Housekeeping: prepare release of extensions-angular #3621

merged 4 commits into from
Sep 20, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Sep 20, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3439

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-3439-make-extensions-publishable September 20, 2024 09:55 Inactive
@github-actions github-actions bot temporarily deployed to pr-3439-make-extensions-publishable September 20, 2024 09:59 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the title Housekeeping: Prepare release of extensions-angular Housekeeping: prepare release of extensions-angular Sep 20, 2024
@RasmusKjeldgaard RasmusKjeldgaard added the ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby label Sep 20, 2024
jakobe
jakobe approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@RasmusKjeldgaard RasmusKjeldgaard merged commit cbbd183 into develop Sep 20, 2024
9 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/3439-make-extensions-publishable branch September 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobe jakobe jakobe approved these changes

Assignees
No one assigned
Labels
ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make extensions publishable
2 participants
@RasmusKjeldgaard @jakobe