Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Add tab and tab row components #25

Closed
kirill-grouchnikov opened this issue Apr 20, 2022 Discussed in #24 · 1 comment
Closed

[Component] Add tab and tab row components #25

kirill-grouchnikov opened this issue Apr 20, 2022 Discussed in #24 · 1 comment
Assignees
@kirill-grouchnikov
Labels
1.2 - Cryo Release 1.2 - 2022.H1

Comments

@kirill-grouchnikov
Copy link
Owner

Discussed in #24

Originally posted by russellbanks April 19, 2022
Is it possible we could get tabs, similar to what is implemented in Radiance but native for JetBrains Compose?
@kirill-grouchnikov kirill-grouchnikov added the 1.2 - Cryo Release 1.2 - 2022.H1 label Apr 20, 2022
@kirill-grouchnikov kirill-grouchnikov self-assigned this Apr 20, 2022
kirill-grouchnikov added a commit that referenced this issue May 3, 2022
@kirill-grouchnikov
First pass for tab components
c18eee6 
Add content and presentation models, wire the layout and scrollability (the code is almost identical to the breadcrumb bar).

For #25
kirill-grouchnikov added a commit that referenced this issue May 4, 2022
@kirill-grouchnikov
Second pass for tab components
fbad17b 
Add layout configuration to the presentation model to configure paddings and margins. For #25
kirill-grouchnikov added a commit that referenced this issue May 6, 2022
@kirill-grouchnikov
Third pass for tab components
db4369e 
* Use a new `AuroraTabButton` for rendering tab buttons. The code is almost identical to the action part of `AuroraCommandButton` (might consider folding this new composable into the existing one at some point if necessary)
* The main difference is the application of a custom runtime shader to the fill painter to provide the target visuals (from Radiance). The selected tab does not show full height fill gradient, but rather only displays a portion of that gradient at the top.
* The displayed amount is configured by two floats, `tabStartFade` and `tabEndFade`. These will be added to individual skins in the next pass.
* For now until Compose Desktop switches to the version of Skiko that has support for runtime shaders, bring that version explicitly in the build configuration.

For #25
kirill-grouchnikov added a commit that referenced this issue May 6, 2022
@kirill-grouchnikov
Fourth pass for tab components
4cf3074 
Add tab start / end for specific skins. For #25
kirill-grouchnikov added a commit that referenced this issue May 6, 2022
@kirill-grouchnikov
Fifth pass for tab components
3d53b84 
Correct tab text color that accounts for partial active tab background. For #25
kirill-grouchnikov added a commit that referenced this issue May 8, 2022
@kirill-grouchnikov
Sixth pass for tab components
83a52e3 
Line under the tabs. For #25
kirill-grouchnikov added a commit that referenced this issue May 8, 2022
@kirill-grouchnikov
Seventh pass for tab components
ce2d52f 
Add content separator kind to allow configuring single-line or double-line (default) separator under the tabs. For #25
kirill-grouchnikov added a commit that referenced this issue May 8, 2022
@kirill-grouchnikov
Add tabs to the list of Aurora components
dcfb361 
For #25
@kirill-grouchnikov
Copy link
Owner Author

See https://github.com/kirill-grouchnikov/aurora/blob/icicle/demo/src/desktopMain/kotlin/org/pushingpixels/aurora/demo/AuroraTabsDemo.kt for a small demo

kirill-grouchnikov added a commit that referenced this issue May 9, 2022
@kirill-grouchnikov
Add configurable content padding to tabs
6397805 
Set by default to have wider horizontal paddings (consistent with Radiance) and update the screenshots. Also rename tab-level presentation model attributes to be prefixed with `tab`.

For #25
kirill-grouchnikov added a commit that referenced this issue May 9, 2022
@kirill-grouchnikov
Fix RTL mode for tabs
368f3a7 
Full RTL support for tabs. For #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
1.2 - Cryo Release 1.2 - 2022.H1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov