[Component] Breadcrumb current path lost on changing Radiance skin

[kirill-grouchnikov]

No description provided.

[kirill-grouchnikov]

There are two parts of it. The first one is showing the breadcrumb bar content itself. That is "skipped" in here where the UI delegate resets the content of the bar to its root. This is what is causing the "loss" of the content. It's not a problem on the first creation of JBreadcrumbBar as the model is created in the constructor and then the UI delegate is first initialized. This can be addressed by checking the breadcrumb bar model in the method linked above and recreating the content if the model is not empty.

The second part will require revisiting how breadcrumb bar works with content icons, and that is something that is going to be backwards incompatible. Right now, it is working with the core Icon interface, which is not scaling at all in the world of light/dark/mixed skins. That can already be seen today in showing the file system under something like Magellan or Graphite skins. The folder icons (from FileSystemView.getSystemIcon that eventually use the "FileView.directoryIcon" entry in UIManager) do not change their color on rollovers. These Icon implementations are then wrapped in RadianceIcon ones (here and here) but of course there's no support for IconFilterStrategy in there.

There is a rather awkward way to add a new method to BreadcrumbBarContentProvider to recreate the content after skin switch, but it's not the cleanest, and will also not address the core issue of using fixed-appearance icons in a mixed-appearance Radiance world.

So the first thing to do is to address the main content issue. Then, it will be switching BreadcrumbItem to use RadianceIcon, adding APIs to JBreadcrumbBar to control icon filter strategy, and then revisiting the existing FileSystemContentProvider and TreeContentProvider on how they work with icons.