-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Animation] Choppy animations, especially on higher refresh rates #380
Comments
I've made a video to compare the behavior before and after the change in the PR. I set output.mp4 |
PR merged. Thanks! |
Marking as breaking change since this has removed the existing public API. |
What public API has this removed? The only removed class is |
Yes, you are right, it was private - https://github.com/kirill-grouchnikov/radiance/blob/v5.0.0/animation/src/main/java/org/pushingpixels/radiance/animation/api/RadianceAnimationCortex.java#L78 Removing the label |
Version of Radiance (latest development is 6.0-SNAPSHOT)
6.0-SNAPSHOT
Sub-project (Common, Animation, Theming, Component, ...)
Animation
Version of Java (current minimum is 9)
Any
Version of OS
Any
The issue you're experiencing (expected vs actual, screenshot, stack trace etc)
Expected:
Animations should be as smooth as possible by default
Actual:
The
DefaultPulseSource
uses 40 ms as the delay between pulses. This arbitrary delay is pretty large and it causes animations to be a bit choppy on high refresh-rate monitors.I don't find the hardcoded 40 ms to be a good default. I propose to derive the default delay from the connected display refresh rate.
The text was updated successfully, but these errors were encountered: