Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theming] Simplified visuals of tabbed panes #389

Closed
kirill-grouchnikov opened this issue Jun 17, 2022 · 0 comments
Closed

[Theming] Simplified visuals of tabbed panes #389

kirill-grouchnikov opened this issue Jun 17, 2022 · 0 comments
Assignees
@kirill-grouchnikov
Labels
6.0 - Iridium Release 6.0 - 2022.H2 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

This will track the work on simplifying the visuals of tabbed panes. Specifically:

  • Remove SINGLE_FULL and DOUBLE_FULL from TabContentPaneBorderKind. Apps that wish to draw border around the content area will need to do so explicitly.
  • Remove RadianceSkin.setTabFadeStart and RadianceSkin.setTabFadeEnd and do consistent indication for the selected / rollover tab with no alpha fade gradient.
  • Consistent corner radius of tabs across all skins.

In addition to more consistent visual appearance across all skins and removal of visual noise (same as was done earlier in scroll panes), it will remove a major blocker for Project Blade. The current implementation of applying a vertical fade on top of tab visuals created by the current fill and border painters does not seem to have a path forward for converting to direct rendering. The Graphics2D.setComposite API can accept custom application composite, but that only works for offscreen images and not direct rendering - an issue that has been known since 2008.

The new visuals will be mirroring the current ones found in skins like Sentinel and Twilight:

sentinel1

twilight1
@kirill-grouchnikov kirill-grouchnikov added Breaking change Marking changes that break backwards compatibility 6.0 - Iridium Release 6.0 - 2022.H2 labels Jun 17, 2022
@kirill-grouchnikov kirill-grouchnikov self-assigned this Jun 17, 2022
kirill-grouchnikov added a commit that referenced this issue Jun 18, 2022
@kirill-grouchnikov
Remove SINGLE_FULL and DOUBLE_FULL from TabContentPaneBorderKind
a40f0e3 
For #389
kirill-grouchnikov added a commit that referenced this issue Jun 18, 2022
@kirill-grouchnikov
Fixed slightly rounded corners on tabs
51f798e 
For #389
kirill-grouchnikov added a commit that referenced this issue Jun 18, 2022
@kirill-grouchnikov
Consistent color of tabbed pane content border
d8e8c40 
For #389
kirill-grouchnikov added a commit that referenced this issue Jun 18, 2022
@kirill-grouchnikov
Simplified visuals for tabs in selected and rollover states
7bad3ec 
For #389
kirill-grouchnikov added a commit that referenced this issue Jun 18, 2022
@kirill-grouchnikov
Remove tab fade APIs from skins
a172bc4 
For #389
kirill-grouchnikov added a commit that referenced this issue Jun 19, 2022
@kirill-grouchnikov
Simplify and remove unreachable code
dd9e340 
With recent visual simplifications of tabbed panes for #389 some code in content border painting is no longer reachable and can be removed
@kirill-grouchnikov kirill-grouchnikov mentioned this issue Jun 22, 2022
Closed
@kirill-grouchnikov kirill-grouchnikov changed the title [Component] Simplified visuals of tabbed panes [Theming] Simplified visuals of tabbed panes Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
6.0 - Iridium Release 6.0 - 2022.H2 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov